Allow menu items to be edited again
ClosedPublic
Actions

Authored by epriestley on Jan 31 2017, 9:26 PM.

Details

Reviewers

chad

Maniphest Tasks

T12174: Home Menu Errata

Commits

rPb2de1490093c: Allow menu items to be edited again

Summary

Ref T12174. We now require that we can figure out a valid "edit mode" (global vs custom/personal) before we hit EditEngine. Since the EditEngine routes don't have an itemID, they would failu to figure out the mode and just 404.

Let the engine use id (from EditEngine) if itemID (from MenuEngine) isn't present in the route.

Test Plan

Edited some menu items on Home / Projects.
(I think I tested this, then broke it, originally.)

Diff Detail

Repository

rP Phabricator

Branch

home6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15466
Build 20382: Run Core Tests
Build 20381: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 31 2017, 9:26 PM

Harbormaster completed remote builds in B15466: Diff 41568.Jan 31 2017, 9:26 PM

Harbormaster completed remote builds in B15466: Diff 41568.

chad accepted this revision.Jan 31 2017, 9:30 PM

This revision is now accepted and ready to land.Jan 31 2017, 9:30 PM

Closed by commit rPb2de1490093c: Allow menu items to be edited again (authored by epriestley, committed by epriestley). · Explain WhyJan 31 2017, 9:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorProfileMenuEngine.php

7 lines

Diff 41568

View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Allow menu items to be edited againClosedPublicActions