Differential D17228
Don't require edit capability on the Favorites application to edit personal menu items Authored by epriestley on Jan 19 2017, 7:11 PM. Tags None Referenced Files
Subscribers
Details Ref T11096. Currently, editing ProfileMenuItemConfigurations always requires that you can edit the corresponding object. This is correct for global items (for example: you can't change the global menu for a project unless you can edit the project) but not for personal items. For personal items, only require that the user can edit the customPHID object. Today, this is always their own profile. As a non-admin, edited personal menu items.
Diff Detail
Event TimelineComment Actions Yeah, non-admins editing their own items. (I tested a bit as as a non-admin but didn't try to customize the menu, and customized the menu only as an admin.) Comment Actions Is there any way that getCustomPHID would return false/null when it's a non-admin editing favorites? I got this report, which seems like the same issue: https://phabricator.wikimedia.org/T156360 |