Page MenuHomePhabricator

Don't require edit capability on the Favorites application to edit personal menu items
ClosedPublic

Authored by epriestley on Jan 19 2017, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 5, 2:58 AM
Unknown Object (File)
Mon, Jun 27, 10:01 AM
Unknown Object (File)
Fri, Jun 17, 11:57 PM
Unknown Object (File)
Mon, Jun 13, 1:17 AM
Unknown Object (File)
Sat, Jun 11, 6:08 PM
Unknown Object (File)
Jun 2 2022, 1:51 AM
Unknown Object (File)
May 31 2022, 12:41 AM
Unknown Object (File)
May 30 2022, 8:09 PM
Subscribers

Details

Summary

Ref T11096. Currently, editing ProfileMenuItemConfigurations always requires that you can edit the corresponding object.

This is correct for global items (for example: you can't change the global menu for a project unless you can edit the project) but not for personal items.

For personal items, only require that the user can edit the customPHID object. Today, this is always their own profile.

Test Plan

As a non-admin, edited personal menu items.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

How should we have caught this? Non-admin testing?

This revision is now accepted and ready to land.Jan 19 2017, 7:13 PM

Yeah, non-admins editing their own items.

(I tested a bit as as a non-admin but didn't try to customize the menu, and customized the menu only as an admin.)

This revision was automatically updated to reflect the committed changes.

Is there any way that getCustomPHID would return false/null when it's a non-admin editing favorites?

I got this report, which seems like the same issue: https://phabricator.wikimedia.org/T156360

Haven't seen other reports, not sure how to reproduce that.

AH ok I can reproduce, will file something