Page MenuHomePhabricator

Clean up "reorder" permissions in MenuEngine for personal favorites
ClosedPublic

Authored by epriestley on Jan 27 2017, 3:45 AM.
Tags
None
Referenced Files
F12831859: D17257.diff
Thu, Mar 28, 1:02 PM
Unknown Object (File)
Fri, Mar 15, 4:03 PM
Unknown Object (File)
Fri, Mar 15, 4:03 PM
Unknown Object (File)
Fri, Mar 8, 3:19 PM
Unknown Object (File)
Fri, Mar 8, 3:10 PM
Unknown Object (File)
Feb 13 2024, 4:27 PM
Unknown Object (File)
Feb 8 2024, 12:12 AM
Unknown Object (File)
Jan 22 2024, 7:24 PM
Subscribers
None

Details

Summary

Fixes T12159. This is similar to D17228, which fixed this for the main configuration operation.

Most other edit operations only test for edit capability on the MenuItem itself, which we already do correctly. However, because reordering affects all items, we test for capability on the object.

Weaken this when reordering custom items.

Test Plan

Reordered custom items in Favorites as a non-administrator.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 27 2017, 3:45 AM

npz

Also I didn't write it anywhere up there ^^^ but I made some kind of effort to double check everything else and I think this is the only one I missed so hopefully we're good now.

This revision was automatically updated to reflect the committed changes.