Differential D17257

Clean up "reorder" permissions in MenuEngine for personal favorites
ClosedPublic
Actions

Authored by epriestley on Jan 27 2017, 3:45 AM.

Details

Reviewers

chad

Maniphest Tasks

T12159: Re-ordering (non-admin) Favorites causes No Permission dialog

Commits

rP9829ecddd695: Clean up "reorder" permissions in MenuEngine for personal favorites

Summary

Fixes T12159. This is similar to D17228, which fixed this for the main configuration operation.

Most other edit operations only test for edit capability on the MenuItem itself, which we already do correctly. However, because reordering affects all items, we test for capability on the object.

Weaken this when reordering custom items.

Test Plan

Reordered custom items in Favorites as a non-administrator.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 27 2017, 3:45 AM

thx :3

chad accepted this revision.Jan 27 2017, 3:45 AM

This revision is now accepted and ready to land.Jan 27 2017, 3:45 AM

Harbormaster completed remote builds in B15394: Diff 41512.Jan 27 2017, 3:46 AM

npz

Also I didn't write it anywhere up there ^^^ but I made some kind of effort to double check everything else and I think this is the only one I missed so hopefully we're good now.

Closed by commit rP9829ecddd695: Clean up "reorder" permissions in MenuEngine for personal favorites (authored by epriestley, committed by epriestley). · Explain WhyJan 27 2017, 3:47 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorProfileMenuEngine.php

32 lines

Diff 41513

View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Clean up "reorder" permissions in MenuEngine for personal favoritesClosedPublicActions