Page MenuHomePhabricator

Clean up "reorder" permissions in MenuEngine for personal favorites
ClosedPublic

Authored by epriestley on Jan 27 2017, 3:45 AM.
Tags
None
Referenced Files
F18278570: D17257.id.diff
Fri, Aug 22, 8:50 PM
F18112121: D17257.id41513.diff
Tue, Aug 12, 4:01 PM
F18112120: D17257.id41512.diff
Tue, Aug 12, 4:01 PM
F18112118: D17257.id.diff
Tue, Aug 12, 4:01 PM
F18109897: D17257.diff
Mon, Aug 11, 3:23 PM
F18090798: D17257.id41512.diff
Wed, Aug 6, 5:38 PM
F18090383: D17257.id41513.diff
Wed, Aug 6, 3:36 PM
F18082882: D17257.id.diff
Tue, Aug 5, 7:44 AM
Subscribers
None

Details

Summary

Fixes T12159. This is similar to D17228, which fixed this for the main configuration operation.

Most other edit operations only test for edit capability on the MenuItem itself, which we already do correctly. However, because reordering affects all items, we test for capability on the object.

Weaken this when reordering custom items.

Test Plan

Reordered custom items in Favorites as a non-administrator.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 27 2017, 3:45 AM

npz

Also I didn't write it anywhere up there ^^^ but I made some kind of effort to double check everything else and I think this is the only one I missed so hopefully we're good now.

This revision was automatically updated to reflect the committed changes.