Restore missing behavior for Differential keyboard navigation
ClosedPublic
Actions

Authored by epriestley on Jan 9 2017, 8:56 PM.

Tags

None

Referenced Files

	F14028358: D17166.id.diff
	Fri, Nov 8, 12:57 PM

	F13988356: D17166.id41282.diff
	Mon, Oct 21, 2:52 PM

	F13985136: D17166.id41282.diff
	Sun, Oct 20, 6:13 PM

	F13963279: D17166.diff
	Tue, Oct 15, 3:05 PM

	Unknown Object (File)
	Sun, Oct 13, 5:41 AM

	Unknown Object (File)
	Oct 7 2024, 11:24 AM

	Unknown Object (File)
	Sep 30 2024, 7:25 PM

	Unknown Object (File)
	Sep 25 2024, 4:28 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12086: Differential keyboard shortcuts for navigating diffs disappeared in the last update

Commits

rPfda83094ac59: Restore missing behavior for Differential keyboard navigation

Summary

Fixes T12086. This got dropped by accident while cleaning up haunting.

Test Plan

Loaed a revision, hit "?", hit n/j/p/etc

Diff Detail

Repository

rP Phabricator

Branch

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15169
Build 19929: Run Core Tests
Build 19928: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 9 2017, 8:56 PM

chad accepted this revision.Jan 9 2017, 8:56 PM

This revision is now accepted and ready to land.Jan 9 2017, 8:56 PM

Harbormaster completed remote builds in B15169: Diff 41282.Jan 9 2017, 8:57 PM

Closed by commit rPfda83094ac59: Restore missing behavior for Differential keyboard navigation (authored by epriestley, committed by epriestley). · Explain WhyJan 9 2017, 8:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

6 lines

Diff 41282

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Restore missing behavior for Differential keyboard navigationClosedPublicActions