HomePhabricator

Make profile menu `/edit/` requests explicitly 404

Description

Make profile menu /edit/ requests explicitly 404

Summary:
See D17160. Previously, the /edit/ route was never linked, but fataled when accessed. Make it 404 instead.

Also, fix an issue where editing "Application" menu items would fail because they didn't have a viewer.

Test Plan:

  • Hit /edit/, got a 404.
  • Edited an "Application" item.
  • Moved, added, deleted, and edited other items.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17165

Details

Provenance
epriestleyAuthored on Jan 9 2017, 7:57 PM
epriestleyPushed on Jan 9 2017, 8:13 PM
Reviewer
chad
Differential Revision
D17165: Make profile menu `/edit/` requests explicitly 404
Parents
rP2dfe79cfc713: When updating revisions in response to commits, reuse previously generated diffs
Branches
Unknown
Tags
Unknown
Build Status
Buildable 15166
Build 19923: Run Core Tests