Fix an issue which could prevent blocking reviewers from being removed from revisions
ClosedPublic
Actions

Authored by epriestley on Jan 9 2017, 4:20 PM.

Tags

None

Referenced Files

	F18082782: D17163.id41272.diff
	Tue, Aug 5, 7:26 AM

	F18081986: D17163.id.diff
	Tue, Aug 5, 3:22 AM

	F18081302: D17163.id41271.diff
	Mon, Aug 4, 11:37 PM

	F18056037: D17163.diff
	Mon, Aug 4, 8:05 AM

	F17990431: D17163.id.diff
	Sat, Aug 2, 12:28 AM

	F17971828: D17163.diff
	Fri, Aug 1, 3:24 PM

	F17970283: D17163.diff
	Fri, Aug 1, 2:40 PM

	Unknown Object (File)
	May 31 2025, 1:28 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T11114: Move Differential to EditEngine

Commits

rP425deeb52391: Fix an issue which could prevent blocking reviewers from being removed from…

Summary

Ref T11114. After evaluating typeahead tokens, we could process blocking reviewer removals incorrectly: we may get structures back.

Test Plan

Removed blocking reviewers from the web UI.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 9 2017, 4:20 PM

Harbormaster completed remote builds in B15158: Diff 41271.Jan 9 2017, 4:21 PM

chad accepted this revision.Jan 9 2017, 4:25 PM

This revision is now accepted and ready to land.Jan 9 2017, 4:25 PM

Closed by commit rP425deeb52391: Fix an issue which could prevent blocking reviewers from being removed from… (authored by epriestley, committed by epriestley). · Explain WhyJan 9 2017, 4:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionReviewersTransaction.php

8 lines

Diff 41272

View Options

src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php

Fix an issue which could prevent blocking reviewers from being removed from revisionsClosedPublicActions