Page MenuHomePhabricator
Differential D17163

Fix an issue which could prevent blocking reviewers from being removed from revisions
ClosedPublic
Actions

Authored by epriestley on Jan 9 2017, 4:20 PM.
Tags
None
Referenced Files
F18812781: D17163.id.diff
Mon, Oct 20, 12:19 PM
F18795059: D17163.id41271.diff
Fri, Oct 17, 1:32 AM
F18759145: D17163.id.diff
Mon, Oct 6, 2:06 AM
F18755548: D17163.diff
Sun, Oct 5, 6:11 AM
F18745579: D17163.diff
Fri, Oct 3, 8:07 AM
F18645225: D17163.id41272.diff
Sep 19 2025, 7:07 AM
F18105753: D17163.id41271.diff
Aug 10 2025, 7:23 PM
F18104274: D17163.id41271.diff
Aug 10 2025, 11:06 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP425deeb52391: Fix an issue which could prevent blocking reviewers from being removed from…
Summary

Ref T11114. After evaluating typeahead tokens, we could process blocking reviewer removals incorrectly: we may get structures back.

Test Plan

Removed blocking reviewers from the web UI.

Diff Detail

Repository
rP Phabricator
Branch
literal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15158
Build 19912: Run Core Tests
Build 19911: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
xaction/
8 lines

Diff 41271

View Options

src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php

Loading...
Phabricator · Built by Phacility