Fix an issue which could prevent blocking reviewers from being removed from revisions
ClosedPublic
Actions

Authored by epriestley on Jan 9 2017, 4:20 PM.

Tags

None

Referenced Files

	F15455333: D17163.id41271.diff
	Sat, Mar 29, 11:34 PM

	F15453799: D17163.id41272.diff
	Sat, Mar 29, 2:26 PM

	F15443294: D17163.id.diff
	Thu, Mar 27, 3:33 AM

	F15439377: D17163.diff
	Wed, Mar 26, 7:16 AM

	F15395255: D17163.id41271.diff
	Sun, Mar 16, 4:25 AM

	F15299289: D17163.id41271.diff
	Mar 5 2025, 2:39 PM

	Unknown Object (File)
	Feb 25 2025, 7:29 AM

	Unknown Object (File)
	Feb 21 2025, 11:50 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T11114: Move Differential to EditEngine

Commits

rP425deeb52391: Fix an issue which could prevent blocking reviewers from being removed from…

Summary

Ref T11114. After evaluating typeahead tokens, we could process blocking reviewer removals incorrectly: we may get structures back.

Test Plan

Removed blocking reviewers from the web UI.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 9 2017, 4:20 PM

Harbormaster completed remote builds in B15158: Diff 41271.Jan 9 2017, 4:21 PM

chad accepted this revision.Jan 9 2017, 4:25 PM

This revision is now accepted and ready to land.Jan 9 2017, 4:25 PM

Closed by commit rP425deeb52391: Fix an issue which could prevent blocking reviewers from being removed from… (authored by epriestley, committed by epriestley). · Explain WhyJan 9 2017, 4:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionReviewersTransaction.php

8 lines

Diff 41272

View Options

src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php

Fix an issue which could prevent blocking reviewers from being removed from revisionsClosedPublicActions