Page MenuHomePhabricator

Make "View" links on Differential inline comment previews work again
ClosedPublic

Authored by epriestley on Jan 2 2017, 6:56 PM.
Tags
None
Referenced Files
F14354164: D17131.id41197.diff
Thu, Dec 19, 5:02 PM
Unknown Object (File)
Mon, Dec 9, 8:22 PM
Unknown Object (File)
Thu, Dec 5, 5:39 AM
Unknown Object (File)
Nov 1 2024, 6:23 AM
Unknown Object (File)
Oct 29 2024, 5:59 AM
Unknown Object (File)
Oct 26 2024, 2:46 AM
Unknown Object (File)
Oct 25 2024, 4:29 PM
Unknown Object (File)
Oct 23 2024, 11:25 PM
Subscribers
None

Details

Summary

Ref T11114. Recent changes broke the links to jump to inline comments from the previews because they get hooked up with JS.

Restore the linking behavior.

Test Plan

Clicked "View" on an inline comment preview, jumped to that comment.

Diff Detail

Repository
rP Phabricator
Branch
diff1
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/diff/behavior-preview-link.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed
Build Status
Buildable 15082
Build 19795: Run Core Tests
Build 19794: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 2 2017, 6:56 PM
This revision was automatically updated to reflect the committed changes.