Page MenuHomePhabricator
Differential D17131

Make "View" links on Differential inline comment previews work again
ClosedPublic
Actions

Authored by epriestley on Jan 2 2017, 6:56 PM.
Tags
None
Referenced Files
F13262352: D17131.diff
Mon, May 27, 2:03 AM
F13247132: D17131.id41200.diff
Thu, May 23, 4:10 PM
F13244651: D17131.diff
Thu, May 23, 5:13 AM
F13233374: D17131.id41197.diff
Tue, May 21, 2:14 AM
F13222970: D17131.diff
Sun, May 19, 4:09 AM
F13205701: D17131.diff
Wed, May 15, 2:17 AM
F13189402: D17131.diff
Sat, May 11, 5:55 AM
Unknown Object (File)
Tue, May 7, 9:47 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rP00313094d3ab: Make "View" links on Differential inline comment previews work again
Summary

Ref T11114. Recent changes broke the links to jump to inline comments from the previews because they get hooked up with JS.

Restore the linking behavior.

Test Plan

Clicked "View" on an inline comment preview, jumped to that comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 2 2017, 6:56 PM
chad accepted this revision.Jan 2 2017, 6:56 PM
This revision is now accepted and ready to land.Jan 2 2017, 6:56 PM
Closed by commit rP00313094d3ab: Make "View" links on Differential inline comment previews work again (authored by epriestley, committed by epriestley). · Explain WhyJan 2 2017, 9:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
diff/
view/
8 lines
webroot/
rsrc/
js/
application/
diff/
36 lines
transactions/
16 lines

Diff 41200

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentPreviewListView.php

Loading...
View Options

webroot/rsrc/js/application/diff/behavior-preview-link.js

Loading...
View Options

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

Loading...
Phabricator · Built by Phacility