Make marking comments as "Done" work cleanly on EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 31 2016, 5:59 PM.

Tags

None

Referenced Files

	F14383297: D17120.diff
	Sat, Dec 21, 6:55 AM

	Unknown Object (File)
	Thu, Dec 19, 2:25 PM

	Unknown Object (File)
	Wed, Dec 11, 2:07 PM

	Unknown Object (File)
	Thu, Dec 5, 7:33 PM

	Unknown Object (File)
	Tue, Dec 3, 11:52 PM

	Unknown Object (File)
	Tue, Dec 3, 11:45 PM

	Unknown Object (File)
	Tue, Dec 3, 11:45 PM

	Unknown Object (File)
	Tue, Dec 3, 11:45 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10323: "Action With No Effect" when marking inline comments as done
T11114: Move Differential to EditEngine

Commits

rP69194fdaf510: Make marking comments as "Done" work cleanly on EditEngine

Summary

Ref T11114. Fixes T10323.

Test Plan

Marked comments as done only: no warning about not leaving a comment.
Did nothing: warning about posting an empty comment.

Diff Detail

Repository

rP Phabricator

Branch

haunt14

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15052
Build 19756: Run Core Tests
Build 19755: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 31 2016, 5:59 PM

chad accepted this revision.Dec 31 2016, 6:00 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 31 2016, 6:00 PM

Closed by commit rP69194fdaf510: Make marking comments as "Done" work cleanly on EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 31 2016, 6:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialRevisionEditEngine.php

25 lines

DifferentialTransactionEditor.php

18 lines

Diff 41164

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php