Page MenuHomePhabricator

Restore "Commandeer" action to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 28 2016, 10:37 PM.
Tags
None
Referenced Files
F18833652: D17111.diff
Sun, Oct 26, 5:05 AM
F18763346: D17111.id.diff
Mon, Oct 6, 11:52 PM
F18757974: D17111.diff
Sun, Oct 5, 8:16 PM
F18631244: D17111.diff
Sep 16 2025, 2:49 PM
F18620950: D17111.diff
Sep 15 2025, 6:43 AM
F18578231: D17111.id41150.diff
Sep 10 2025, 9:32 PM
F18578146: D17111.id41150.diff
Sep 10 2025, 9:18 PM
F18570265: D17111.id41169.diff
Sep 10 2025, 3:18 AM
Subscribers
None

Details

Summary

Ref T11114. This has two pieces of side-effect logic which I've noted locally:

  • Commandeer needs to apply Herald rules.
  • Commandeer needs to move the old author to become a reviewer and remove the actor as a reviewer.
Test Plan

Commandeered some revisions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 6:57 PM
This revision was automatically updated to reflect the committed changes.