Page MenuHomePhabricator

Restore "Commandeer" action to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 28 2016, 10:37 PM.
Tags
None
Referenced Files
F14050360: D17111.diff
Thu, Nov 14, 6:05 PM
F14039157: D17111.diff
Mon, Nov 11, 4:07 AM
F14024776: D17111.diff
Thu, Nov 7, 12:12 PM
F13965368: D17111.id41150.diff
Oct 16 2024, 1:34 AM
F13956769: D17111.id41169.diff
Oct 14 2024, 7:02 AM
Unknown Object (File)
Oct 1 2024, 9:58 PM
Unknown Object (File)
Sep 30 2024, 5:01 AM
Unknown Object (File)
Sep 24 2024, 6:24 AM
Subscribers
None

Details

Summary

Ref T11114. This has two pieces of side-effect logic which I've noted locally:

  • Commandeer needs to apply Herald rules.
  • Commandeer needs to move the old author to become a reviewer and remove the actor as a reviewer.
Test Plan

Commandeered some revisions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 6:57 PM
This revision was automatically updated to reflect the committed changes.