Page MenuHomePhabricator

Allow any EditEngine comment form to be pinned
ClosedPublic

Authored by epriestley on Dec 28 2016, 5:46 PM.
Tags
None
Referenced Files
F13810408: D17105.diff
Tue, Sep 17, 3:15 PM
Unknown Object (File)
Mon, Sep 2, 9:21 PM
Unknown Object (File)
Mon, Sep 2, 9:21 PM
Unknown Object (File)
Mon, Sep 2, 9:21 PM
Unknown Object (File)
Mon, Sep 2, 9:21 PM
Unknown Object (File)
Fri, Aug 23, 4:36 AM
Unknown Object (File)
Tue, Aug 20, 7:57 AM
Unknown Object (File)
Tue, Aug 20, 7:56 AM
Subscribers
None

Details

Summary

Fixes T12049. This expands "Haunted" comment panels to EditEngine, and by extension to all EditEngine applications.

Eventual goal is to remove custom commenting code in Differential and replace it with EditEngine code.

Changes from current "haunt" mode:

  • This only has one mode ("pinned"), not two ("pinned", "pinned with preview"). There's an inline preview and scroll behavior is a little better.
  • Now has a UI action button.

Slightly tricky stuff:

  • This interacts with "Fullscreen" mode since it doesn't make sense to pin a full-screen comment area.
  • This should only be available for comments, not for remarkup fields like "Description" in "Edit Task".
Test Plan
  • Pinned/unpinned in Maniphest.
  • Pinned/fullscreened/unfullscreened/unpinned.
  • Checked that "Edit Task" doesn't allow pinning for "Description", etc.
  • Pressed "?", read about pressing "Z".
  • Pressed "Z".

Diff Detail

Repository
rP Phabricator
Branch
haunt1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15030
Build 19717: Run Core Tests
Build 19716: arc lint + arc unit