Page MenuHomePhabricator

Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine

Authored by epriestley on Dec 16 2016, 1:46 PM.
Referenced Files
Unknown Object (File)
Thu, Jul 18, 8:15 AM
Unknown Object (File)
Thu, Jul 11, 11:22 PM
Unknown Object (File)
Thu, Jul 11, 12:45 AM
Unknown Object (File)
Tue, Jul 9, 6:40 AM
Unknown Object (File)
Fri, Jul 5, 10:27 PM
Unknown Object (File)
Thu, Jul 4, 8:47 PM
Unknown Object (File)
Wed, Jun 26, 4:23 PM
Unknown Object (File)
Tue, Jun 25, 10:53 AM



Ref T11114. This creates differential.revision.edit (a modern, v3 API method) and redefines the existing methods in terms of it.

Both differential.createrevision and differential.updaterevision are now internally implemented by building a differential.revision.edit API call and then executing it.

I think this covers everything except custom fields, which need some tweaking to work with EditEngine. I'll clean that up in the next change.

Test Plan
  • Created, updated, and edited revisions via arc.
  • Called APIs manually via test console.
  • Stored custom fields ("Blame Rev", "Revert Plan") aren't exposed yet.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 3:18 PM
This revision was automatically updated to reflect the committed changes.