Page MenuHomePhabricator

Move Differential commit message rendering to dedicated classes
ClosedPublic

Authored by epriestley on Dec 16 2016, 12:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 10:22 PM
Unknown Object (File)
Wed, Mar 20, 10:22 PM
Unknown Object (File)
Wed, Mar 20, 10:22 PM
Unknown Object (File)
Wed, Mar 20, 10:22 PM
Unknown Object (File)
Feb 11 2024, 7:52 PM
Unknown Object (File)
Feb 3 2024, 1:28 PM
Unknown Object (File)
Jan 29 2024, 4:14 AM
Unknown Object (File)
Jan 21 2024, 1:17 PM
Subscribers
None

Details

Summary

Ref T11114. This probably still has some bugs, but survives basic sanity checks.

Continue pulling commit message logic out of CustomField so we can reduce the amount of responsibility/bloat in the classtree and send more code through EditEngine.

Test Plan
  • Called differential.getcommitmessage via API console for various revisions/parameters (edit and create mode, with and without fields, with and without revisions).
  • Used --create, --edit and --update modes of arc diff from the CLI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Move Differential commit message rendering to dedicated classes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

I've also removed the "pro tips" in commit message templates since I don't get the sense that anyone ever actually read them. We could restore them later if they are missed.

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 3:12 PM
This revision was automatically updated to reflect the committed changes.