Page MenuHomePhabricator

Fix an issue with mentioning revisions on the new EditEngine code
ClosedPublic

Authored by epriestley on Dec 14 2016, 10:01 PM.
Tags
None
Referenced Files
F18832936: D17059.diff
Sat, Oct 25, 11:52 PM
F18791223: D17059.diff
Thu, Oct 16, 6:51 AM
F18772472: D17059.diff
Thu, Oct 9, 2:46 AM
F18761040: D17059.id.diff
Mon, Oct 6, 11:58 AM
F18757086: D17059.diff
Sun, Oct 5, 3:29 PM
F18736056: D17059.id41033.diff
Wed, Oct 1, 4:45 AM
F18722546: D17059.id41035.diff
Mon, Sep 29, 10:50 PM
F18631403: D17059.id41033.diff
Sep 16 2025, 3:15 PM
Subscribers
None

Details

Summary

Ref T12020. Ref T11114. If we continue here on a mention, we try to generate $old, which requires reviewers to be attached. They won't be for simple codepaths like mentions.

Instead, just bail early: we don't need to do anything anyway since we can't possibly find any more errors with zero transactions.

Test Plan

Mentioned a revision on a task.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an issue with mentioning revisions on the new EditEngine code.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, avivey.
avivey edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2016, 10:02 PM
This revision was automatically updated to reflect the committed changes.