Page MenuHomePhabricator
Differential D17049

New quickstart sql
AbandonedPublic
Actions

Authored by chad on Dec 13 2016, 11:40 PM.
Tags
None
Referenced Files
F15274826: D17049.diff
Sat, Mar 1, 1:28 PM
Unknown Object (File)
Mon, Feb 24, 11:53 AM
Unknown Object (File)
Mon, Feb 24, 5:37 AM
Unknown Object (File)
Tue, Feb 18, 12:12 PM
Unknown Object (File)
Sun, Feb 9, 1:16 AM
Unknown Object (File)
Fri, Feb 7, 10:46 PM
Unknown Object (File)
Fri, Feb 7, 6:41 AM
Unknown Object (File)
Jan 25 2025, 1:38 PM
View All Files
Subscribers
Korvin
thoughtpolice

Details

Reviewers
epriestley
Summary

Update quickstart sql

Test Plan

look?

Diff Detail

Repository
rP Phabricator
Branch
quickstart (branched from master)
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningresources/sql/quickstart.sql:1586TXT3Line Too Long
Warningresources/sql/quickstart.sql:1830TXT3Line Too Long
Warningresources/sql/quickstart.sql:3098TXT3Line Too Long
Warningresources/sql/quickstart.sql:3230TXT3Line Too Long
Warningresources/sql/quickstart.sql:3233TXT3Line Too Long
Warningresources/sql/quickstart.sql:6366TXT3Line Too Long
Warningresources/sql/quickstart.sql:6391TXT3Line Too Long
Warningresources/sql/quickstart.sql:6393TXT3Line Too Long
Warningresources/sql/quickstart.sql:6436TXT3Line Too Long
Warningresources/sql/quickstart.sql:6437TXT3Line Too Long
Warningresources/sql/quickstart.sql:6479TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 14899
Build 19514: Run Core Tests
Build 19513: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 41010.Dec 13 2016, 11:40 PM
chad retitled this revision from to New quickstart sql.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 13 2016, 11:40 PM
epriestley edited edge metadata.Dec 13 2016, 11:43 PM

Any particular reason to regenerate it?

chad added a comment.Dec 13 2016, 11:44 PM

my unit tests have been taking ages it feels

epriestley added a comment.Dec 13 2016, 11:47 PM

How fast are they on master versus after regenerating?

epriestley added a comment.Dec 13 2016, 11:48 PM

(There's no real reason not to regenerate this, but I'm a little squeamish about D17039 and this makes the bin/storage upgrade story more complicated.)

chad added a comment.Dec 13 2016, 11:50 PM

I ran it on two machines, maybe --everything is 20 seconds faster. No big deal to wait a few weeks.

epriestley added a comment.Dec 13 2016, 11:58 PM

Hmm, weird -- --everything only takes me 26 seconds total. I assume it's taking longer for you?

But yeah, let's wait a week or so just because I'm doing some really sketchy stuff in Differential.

chad added a comment.Dec 14 2016, 12:11 AM

Hmm, 2:10 on my dev machine vs. :26 on my mac.

epriestley added a comment.Dec 14 2016, 12:14 AM

is ur dev machine an original gameboy that you underclocked

chad added a comment.Dec 14 2016, 12:15 AM

i'll poke around, it's an intel nuc, reasonably quick

epriestley added a comment.Dec 14 2016, 1:22 AM

Screen Shot 2016-12-13 at 5.22.18 PM.png (515×771 px, 540 KB)

thoughtpolice added a subscriber: thoughtpolice.Dec 16 2016, 10:44 PM
In D17049#202017, @epriestley wrote:

is ur dev machine an original gameboy that you underclocked

... is yours not?

epriestley added a comment.Dec 17 2016, 12:34 AM
In D17049#202594, @thoughtpolice wrote:

... is yours not?

Heavens no! I use a hand-carved wooden abacus I made from some pond reeds and a few acorn shells.

chad abandoned this revision.Dec 17 2016, 4:04 AM

Revision Contents
Changeset List

PathSize
resources/
sql/
441 lines

Diff 41010

View Options

resources/sql/quickstart.sql

Loading...
Phabricator · Built by Phacility