Page MenuHomePhabricator
Differential D17008

Validate settings before writing them to the user cache
ClosedPublic
Actions

Authored by epriestley on Dec 7 2016, 8:51 PM.
Tags
None
Referenced Files
F13105985: D17008.diff
Sat, Apr 27, 5:57 PM
Unknown Object (File)
Thu, Apr 25, 12:04 AM
Unknown Object (File)
Tue, Apr 23, 8:54 PM
Unknown Object (File)
Thu, Apr 11, 8:21 AM
Unknown Object (File)
Sat, Apr 6, 4:18 PM
Unknown Object (File)
Thu, Apr 4, 7:19 PM
Unknown Object (File)
Sun, Mar 31, 1:42 AM
Unknown Object (File)
Sat, Mar 30, 7:19 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11960: I probably screwed up caching since times aren't rendering for me in timestamps
Commits
rP495092613019: Validate settings before writing them to the user cache
Summary

Fixes T11960. In D16998 I removed some code which validated settings on read to improve performance, but lost this replacement validation in shuffling the patch stack.

This restores similar validation before we write the cache. This has the same effect, it's just faster.

Also, bump the cache key to wipe out anything that got bitten (like my account on secure rendering dates wrong).

Test Plan
  • Edited settings, verified the edits held.
  • Faked invalid settings, saw the check throw exceptions.

Diff Detail

Repository
rP Phabricator
Branch
cperf1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14805
Build 19366: Run Core Tests
Build 19365: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40917.Dec 7 2016, 8:51 PM
epriestley updated this revision to Diff 40918.
epriestley retitled this revision from to Validate settings before writing them to the user cache.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11960: I probably screwed up caching since times aren't rendering for me in timestamps.
  • Really, truly bump that cache key.
chad accepted this revision.Dec 7 2016, 9:32 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 7 2016, 9:32 PM
Closed by commit rP495092613019: Validate settings before writing them to the user cache (authored by epriestley, committed by epriestley). · Explain WhyDec 7 2016, 9:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
cache/
12 lines

Diff 40918

View Options

src/applications/people/cache/PhabricatorUserPreferencesCacheType.php

Loading...
Phabricator · Built by Phacility