Validate settings before writing them to the user cache
ClosedPublic
Actions

Authored by epriestley on Dec 7 2016, 8:51 PM.

Details

Reviewers

chad

Maniphest Tasks

T11960: I probably screwed up caching since times aren't rendering for me in timestamps

Commits

rP495092613019: Validate settings before writing them to the user cache

Summary

Fixes T11960. In D16998 I removed some code which validated settings on read to improve performance, but lost this replacement validation in shuffling the patch stack.

This restores similar validation before we write the cache. This has the same effect, it's just faster.

Also, bump the cache key to wipe out anything that got bitten (like my account on secure rendering dates wrong).

Test Plan

Edited settings, verified the edits held.
Faked invalid settings, saw the check throw exceptions.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Really, truly bump that cache key.

chad accepted this revision.Dec 7 2016, 9:32 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 7 2016, 9:32 PM

Closed by commit rP495092613019: Validate settings before writing them to the user cache (authored by epriestley, committed by epriestley). · Explain WhyDec 7 2016, 9:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

cache/

PhabricatorUserPreferencesCacheType.php

12 lines

Diff 40922

View Options

src/applications/people/cache/PhabricatorUserPreferencesCacheType.php

Validate settings before writing them to the user cacheClosedPublicActions