Page MenuHomePhabricator
Differential D16996

Slightly modernize ConduitTokenQuery
ClosedPublic
Actions

Authored by epriestley on Dec 6 2016, 12:19 PM.
Tags
None
Referenced Files
F14341736: D16996.id40899.diff
Wed, Dec 18, 8:08 PM
F14341735: D16996.id40888.diff
Wed, Dec 18, 8:08 PM
F14341734: D16996.id.diff
Wed, Dec 18, 8:08 PM
F14341731: D16996.diff
Wed, Dec 18, 8:08 PM
Unknown Object (File)
Mon, Dec 9, 7:28 AM
Unknown Object (File)
Mon, Dec 9, 7:28 AM
Unknown Object (File)
Mon, Dec 9, 7:26 AM
Unknown Object (File)
Mon, Dec 9, 7:17 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching
Commits
rPbfbf75a8720c: Slightly modernize ConduitTokenQuery
Summary

Ref T11954. This old query class can use slightly more modern code.

Test Plan

Ran Conduit methods, verified results are unchanged.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40888.Dec 6 2016, 12:19 PM
epriestley retitled this revision from to Slightly modernize ConduitTokenQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching.
chad accepted this revision.Dec 6 2016, 4:22 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 6 2016, 4:22 PM
Closed by commit rPbfbf75a8720c: Slightly modernize ConduitTokenQuery (authored by epriestley, committed by epriestley). · Explain WhyDec 6 2016, 4:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conduit/
query/
37 lines

Diff 40899

View Options

src/applications/conduit/query/PhabricatorConduitTokenQuery.php

Loading...
Phabricator · Built by Phacility