Differential D16996

Slightly modernize ConduitTokenQuery
ClosedPublic
Actions

Authored by epriestley on Dec 6 2016, 12:19 PM.

Details

Reviewers

chad

Maniphest Tasks

T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching

Commits

rPbfbf75a8720c: Slightly modernize ConduitTokenQuery

Summary

Ref T11954. This old query class can use slightly more modern code.

Test Plan

Ran Conduit methods, verified results are unchanged.

Diff Detail

Repository

rP Phabricator

Branch

ccache4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14774
Build 19317: Run Core Tests
Build 19316: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40888.Dec 6 2016, 12:19 PM

epriestley retitled this revision from to Slightly modernize ConduitTokenQuery.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching.

chad accepted this revision.Dec 6 2016, 4:22 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 6 2016, 4:22 PM

Closed by commit rPbfbf75a8720c: Slightly modernize ConduitTokenQuery (authored by epriestley, committed by epriestley). · Explain WhyDec 6 2016, 4:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

query/

PhabricatorConduitTokenQuery.php

37 lines

Diff 40888

View Options

src/applications/conduit/query/PhabricatorConduitTokenQuery.php

Slightly modernize ConduitTokenQueryClosedPublicActions