Paths

Table of Contentst

Differential D16975

Set the viewer timezone properly on Calendar event RecurrenceSet objects
ClosedPublic
Actions

Authored by epriestley on Dec 2 2016, 12:57 PM.

Details

Reviewers

chad

Maniphest Tasks

T11801: Calendar: ICS Import Errata

Commits

rP7c37377e0d61: Set the viewer timezone properly on Calendar event RecurrenceSet objects

Summary

Ref T11801. In some cases, this could lead to us failing to generate the first recurrence in a series.

Test Plan

Imported weekly.ics (from D16974) and saw an event correctly occur on Aug 18, with my local timezone set to "America/Los_Angeles".

Diff Detail

Repository

rP Phabricator

Branch

cal1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14732
Build 19252: Run Core Tests
Build 19251: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40847.Dec 2 2016, 12:57 PM

epriestley retitled this revision from to Set the viewer timezone properly on Calendar event RecurrenceSet objects.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11801: Calendar: ICS Import Errata.

epriestley mentioned this in T11801: Calendar: ICS Import Errata.Dec 2 2016, 12:58 PM

chad accepted this revision.Dec 2 2016, 3:24 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 2 2016, 3:24 PM

Closed by commit rP7c37377e0d61: Set the viewer timezone properly on Calendar event RecurrenceSet objects (authored by epriestley, committed by epriestley). · Explain WhyDec 2 2016, 3:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

storage/

PhabricatorCalendarEvent.php

4 lines

Diff 40847

View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Set the viewer timezone properly on Calendar event RecurrenceSet objectsClosedPublicActions