Page MenuHomePhabricator
Differential D16878

Make some confusing/weird Calendar fields not configurable on custom EditEngine forms
ClosedPublic
Actions

Authored by epriestley on Nov 16 2016, 2:59 PM.
Tags
None
Referenced Files
F13328675: D16878.diff
Sun, Jun 16, 12:48 PM
F13296471: D16878.diff
Thu, Jun 6, 4:06 PM
F13250584: D16878.id.diff
Fri, May 24, 3:19 PM
F13220471: D16878.id40635.diff
Sun, May 19, 1:32 AM
F13216703: D16878.id40635.diff
Sat, May 18, 1:54 AM
F13214725: D16878.diff
May 17 2024, 12:32 PM
F13182651: D16878.id40635.diff
May 10 2024, 12:40 AM
Unknown Object (File)
May 6 2024, 10:24 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11816: Calendar: Feedback and Suggestions
Commits
rP91ee6b78df3d: Make some confusing/weird Calendar fields not configurable on custom EditEngine…
Summary

Ref T11816.

  • Host gets weird behavior around defaulting to the viewer.
  • Invitees get weird behavior around defaulting to the viewer.
  • "All Day" is just sort of weird since start / end date aren't customizable.
  • Recurring/Frequency are weird here and don't make much sense.

I can't immediately come up with reasons that any of these are particularly useful/valuable to default. More of them can be made editable after T10222 gets sorted out.

Test Plan

Edited edit engine custom forms for Calendar events, saw a more sensible list of customizable fields (e.g., policy stuff).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40635.Nov 16 2016, 2:59 PM
epriestley retitled this revision from to Make some confusing/weird Calendar fields not configurable on custom EditEngine forms.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11816: Calendar: Feedback and Suggestions.
chad accepted this revision.Nov 16 2016, 3:10 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2016, 3:10 PM
Closed by commit rP91ee6b78df3d: Make some confusing/weird Calendar fields not configurable on custom EditEngine… (authored by epriestley, committed by epriestley). · Explain WhyNov 16 2016, 3:49 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11816: Calendar: Feedback and Suggestions.Nov 16 2016, 3:53 PM

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
editor/
10 lines

Diff 40640

View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditEngine.php

Loading...
Phabricator · Built by Phacility