Page MenuHomePhabricator

Make some confusing/weird Calendar fields not configurable on custom EditEngine forms
ClosedPublic

Authored by epriestley on Nov 16 2016, 2:59 PM.
Tags
None
Referenced Files
F13296471: D16878.diff
Thu, Jun 6, 4:06 PM
F13250584: D16878.id.diff
Fri, May 24, 3:19 PM
F13220471: D16878.id40635.diff
Sun, May 19, 1:32 AM
F13216703: D16878.id40635.diff
Sat, May 18, 1:54 AM
F13214725: D16878.diff
Fri, May 17, 12:32 PM
F13182651: D16878.id40635.diff
May 10 2024, 12:40 AM
Unknown Object (File)
May 6 2024, 10:24 AM
Unknown Object (File)
May 1 2024, 11:08 PM
Subscribers
None

Details

Summary

Ref T11816.

  • Host gets weird behavior around defaulting to the viewer.
  • Invitees get weird behavior around defaulting to the viewer.
  • "All Day" is just sort of weird since start / end date aren't customizable.
  • Recurring/Frequency are weird here and don't make much sense.

I can't immediately come up with reasons that any of these are particularly useful/valuable to default. More of them can be made editable after T10222 gets sorted out.

Test Plan

Edited edit engine custom forms for Calendar events, saw a more sensible list of customizable fields (e.g., policy stuff).

Diff Detail

Repository
rP Phabricator
Branch
cal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14523
Build 18940: Run Core Tests
Build 18939: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make some confusing/weird Calendar fields not configurable on custom EditEngine forms.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2016, 3:10 PM
This revision was automatically updated to reflect the committed changes.