Fixes T4245. When a repository has a short name, use /source/shortname/ as its primary URI.
Details
- Reviewers
chad - Maniphest Tasks
- T4245: Make repository URIs slightly prettier
- Commits
- rP6a62fca95093: Support slightly prettier repository URIs in Diffusion
- Cloned Git repositories from shortnames via HTTP and SSH.
- Cloned Mercurial repositories from shortnames via HTTP and SSH.
- Cloned Subversion repositories from shortnames via SSH.
- Browsed Git, Mercurial and Subversion repositories.
- Added and removed short names to various repositories.
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
src/applications/diffusion/controller/DiffusionLastModifiedController.php | ||
---|---|---|
19 |
src/applications/diffusion/controller/DiffusionLastModifiedController.php | ||
---|---|---|
19 | o i c |
We default "short name" to a mangled version of the repository name, which is often "good enough" (looks like all repos here don't have short-name explicitly set), but we don't consider it a "short name" for this feature.
Right now, a few of my repos (The ones with the confusing names) show the /source/short-name.git, and most show /diffusion/<id>/short-name.git, which I suspect would ends up confusing for users.
We don't consider the "clone name" to be a "short name" for the purposes of this feature because it is not guaranteed to be unique (many different names mangle down to the same "clone name", and repositories are not required to have unique names in the first place).
Ahh, that makes sense.
The UI is a little confusing around this though, because it refers to both "clone name" and "repository slug" as "short name" in the manage page; I'll try to break that up a bit?
Short Name: none |
Clone As: yellow-fruit (Automatic clone name) |
Short Name: green-tomatoes |
Clone As: green-tomatoes (Short name) |
Maybe just remove "Clone As" completely? e.g., only show:
Short Name: the-short-name
...or:
Short Name: None (or just don't show anything idk)