Page MenuHomePhabricator

Improve typeahead behavior with mixed-case matches
ClosedPublic

Authored by epriestley on Nov 8 2016, 7:40 PM.
Tags
None
Referenced Files
F11050606: D16826.id40517.diff
Sat, Aug 20, 12:05 AM
Unknown Object (File)
Thu, Aug 18, 10:10 AM
Unknown Object (File)
Mon, Aug 15, 11:47 PM
Unknown Object (File)
Mon, Aug 15, 2:40 PM
Unknown Object (File)
Sat, Aug 13, 5:47 AM
Unknown Object (File)
Mon, Aug 8, 6:51 PM
Unknown Object (File)
Wed, Aug 3, 10:51 PM
Unknown Object (File)
Wed, Aug 3, 7:33 PM
Subscribers
None

Details

Summary

Ref T8510. We had two issues with mixed-case result sorting, like typing @joe to match user Joe.

  • The fallback sort was not normalized properly, so "J" could sort after "j". Instead, normalize values for sorting.
  • The prefix_hits and older priority_hits mechanisms were competing destructively. The prefix_hits mechanism completely replaces the priority_hits mechanism. Instead, use only the prefix_hits mechanism.
Test Plan
  • Copied results for "joe" from WMF.
  • Hard-coded the controller to return them.
  • Searched for @joe.
  • After patches, first hit is user "Joe".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve typeahead behavior with mixed-case matches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2016, 7:41 PM
This revision was automatically updated to reflect the committed changes.