Differential D16663

Use more CalendarDateTime and fewer epoch timestamps in Calendar
ClosedPublic
Actions

Authored by epriestley on Oct 4 2016, 6:51 PM.

Tags

None

Referenced Files

	F21584311: D16663.diff
	Tue, Aug 4, 1:39 PM

	Unknown Object (File)
	Sun, Jul 12, 12:19 AM

	Unknown Object (File)
	May 30 2026, 8:34 AM

	Unknown Object (File)
	Apr 17 2026, 2:09 AM

	Unknown Object (File)
	Apr 16 2026, 9:17 PM

	Unknown Object (File)
	Mar 4 2026, 5:32 AM

	Unknown Object (File)
	Feb 17 2026, 7:07 PM

	Unknown Object (File)
	Jan 17 2026, 5:14 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPfae0ec9220a7: Use more CalendarDateTime and fewer epoch timestamps in Calendar

Summary

Ref T10747. Moves away from getDateFrom() / getDateTo() and makes a few more date/time methods more consistent.

Test Plan

Created, edited, viewed events.

Diff Detail

Repository

Branch

cal6

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/calendar/xaction/PhabricatorCalendarEventEndDateTransaction.php:9	XHP16	TODO Comment
Advice	src/applications/calendar/xaction/PhabricatorCalendarEventStartDateTransaction.php:9	XHP16	TODO Comment
Advice	src/applications/calendar/xaction/PhabricatorCalendarEventUntilDateTransaction.php:9	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 14006
Build 18158: Run Core Tests
Build 18157: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40116.Oct 4 2016, 6:51 PM

epriestley retitled this revision from to Use more CalendarDateTime and fewer epoch timestamps in Calendar.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Oct 4 2016, 8:02 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 4 2016, 8:02 PM

Closed by commit rPfae0ec9220a7: Use more CalendarDateTime and fewer epoch timestamps in Calendar (authored by epriestley, committed by epriestley). · Explain WhyOct 6 2016, 10:53 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

editor/

PhabricatorCalendarEventEditEngine.php

9 lines

PhabricatorCalendarEventEditor.php

8 lines

storage/

PhabricatorCalendarEvent.php

16 lines

xaction/

PhabricatorCalendarEventEndDateTransaction.php

3 lines

PhabricatorCalendarEventStartDateTransaction.php

3 lines

PhabricatorCalendarEventUntilDateTransaction.php

3 lines

people/

query/

PhabricatorPeopleQuery.php

2 lines

Diff 40116

src/applications/calendar/editor/PhabricatorCalendarEventEditEngine.php

Loading...

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...

src/applications/calendar/xaction/PhabricatorCalendarEventEndDateTransaction.php

Loading...

src/applications/calendar/xaction/PhabricatorCalendarEventStartDateTransaction.php

Loading...

src/applications/calendar/xaction/PhabricatorCalendarEventUntilDateTransaction.php

Loading...

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...