Page MenuHomePhabricator
Differential D16663

Use more CalendarDateTime and fewer epoch timestamps in Calendar
ClosedPublic
Actions

Authored by epriestley on Oct 4 2016, 6:51 PM.
Tags
None
Referenced Files
F13157427: D16663.diff
Sun, May 5, 11:49 AM
Unknown Object (File)
Fri, May 3, 4:01 AM
Unknown Object (File)
Mon, Apr 29, 4:15 PM
Unknown Object (File)
Fri, Apr 26, 4:10 PM
Unknown Object (File)
Thu, Apr 25, 7:03 PM
Unknown Object (File)
Wed, Apr 24, 11:58 PM
Unknown Object (File)
Fri, Apr 19, 5:25 PM
Unknown Object (File)
Thu, Apr 11, 8:15 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rPfae0ec9220a7: Use more CalendarDateTime and fewer epoch timestamps in Calendar
Summary

Ref T10747. Moves away from getDateFrom() / getDateTo() and makes a few more date/time methods more consistent.

Test Plan

Created, edited, viewed events.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40116.Oct 4 2016, 6:51 PM
epriestley retitled this revision from to Use more CalendarDateTime and fewer epoch timestamps in Calendar.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Oct 4 2016, 8:02 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 4 2016, 8:02 PM
Closed by commit rPfae0ec9220a7: Use more CalendarDateTime and fewer epoch timestamps in Calendar (authored by epriestley, committed by epriestley). · Explain WhyOct 6 2016, 10:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40147

View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditEngine.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventEndDateTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventStartDateTransaction.php

Loading...
View Options

src/applications/calendar/xaction/PhabricatorCalendarEventUntilDateTransaction.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...
Phabricator · Built by Phacility