Page MenuHomePhabricator
Differential D16645

Revert "Clean up more Quicksand"
ClosedPublic
Actions

Authored by chad on Oct 1 2016, 7:36 PM.
Tags
None
Referenced Files
F12342960: D16645.diff
Mon, Dec 11, 2:38 PM
Unknown Object (File)
Thu, Nov 30, 6:14 AM
Unknown Object (File)
Sat, Nov 25, 8:32 AM
Unknown Object (File)
Sat, Nov 25, 6:34 AM
Unknown Object (File)
Sun, Nov 19, 7:52 AM
Unknown Object (File)
Mon, Nov 13, 10:53 AM
Unknown Object (File)
Nov 6 2023, 7:14 AM
Unknown Object (File)
Oct 24 2023, 2:48 AM
View All 94 Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T11718: 2 scroll bars appear on all pages
Commits
rP87ebb80059f0: Revert "Clean up more Quicksand"
Summary

This reverts commit 5eb4bc6ca960aa0eafaa25591baea102ff4e034b.

Test Plan

Reload homepage, no scrollbars

Diff Detail

Repository
rP Phabricator
Branch
revert (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13963
Build 18089: Run Core Tests
Build 18088: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40072.Oct 1 2016, 7:36 PM
chad retitled this revision from to Revert "Clean up more Quicksand".
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 1 2016, 7:36 PM
epriestley accepted this revision.Oct 1 2016, 7:46 PM
epriestley edited edge metadata.

I think this approach is maybe slightly more promising, but your call.

This revision is now accepted and ready to land.Oct 1 2016, 7:46 PM
chad added a comment.Oct 1 2016, 7:47 PM

which approach? reverting and going with body classes or faking a background on all pages?

chad added a comment.Oct 1 2016, 7:49 PM

can I just pass body classes in via quicksand config?

chad added a comment.Oct 1 2016, 7:49 PM

i am just a corgi. javascript is hard.

epriestley added a comment.Oct 1 2016, 7:52 PM

Yes, I think.

  • Have buildQuicksandConfig() in PhabricatorStandardPageView include a key like bodyClasses.
  • In behavior-durable-column in the existing quicksand-redraw listener, do document.body.className = new_data.bodyClasses or similar.
Closed by commit rP87ebb80059f0: Revert "Clean up more Quicksand" (authored by chad, committed by chad). · Explain WhyOct 1 2016, 7:58 PM
This revision was automatically updated to reflect the committed changes.
Luke081515.2 added a task: T11718: 2 scroll bars appear on all pages.Oct 1 2016, 10:16 PM

Revision Contents
Changeset List

Diff 40072

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigAllController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigApplicationController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigCacheController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigClusterRepositoriesController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigGroupController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigHistoryController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIssueListController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIssueViewController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigListController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigModuleController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigVersionController.php

Loading...
View Options

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
View Options

webroot/rsrc/css/application/search/application-search-view.css

Loading...
View Options

webroot/rsrc/css/core/core.css

Loading...
View Options

webroot/rsrc/css/phui/phui-basic-nav-view.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workboard-color.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workboard.css

Loading...
Phabricator · Built by Phacility