Page MenuHomePhabricator

Revert "Clean up more Quicksand"

Authored by chad on Oct 1 2016, 7:36 PM.
Referenced Files
F12342960: D16645.diff
Mon, Dec 11, 2:38 PM
Unknown Object (File)
Thu, Nov 30, 6:14 AM
Unknown Object (File)
Sat, Nov 25, 8:32 AM
Unknown Object (File)
Sat, Nov 25, 6:34 AM
Unknown Object (File)
Sun, Nov 19, 7:52 AM
Unknown Object (File)
Mon, Nov 13, 10:53 AM
Unknown Object (File)
Nov 6 2023, 7:14 AM
Unknown Object (File)
Oct 24 2023, 2:48 AM


Test Plan

Reload homepage, no scrollbars

Diff Detail

rP Phabricator
revert (branched from master)
Lint Passed
Tests Passed
Build Status
Buildable 13963
Build 18089: Run Core Tests
Build 18088: arc lint + arc unit

Event Timeline

chad retitled this revision from to Revert "Clean up more Quicksand".
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

I think this approach is maybe slightly more promising, but your call.

This revision is now accepted and ready to land.Oct 1 2016, 7:46 PM

which approach? reverting and going with body classes or faking a background on all pages?

can I just pass body classes in via quicksand config?

i am just a corgi. javascript is hard.

Yes, I think.

  • Have buildQuicksandConfig() in PhabricatorStandardPageView include a key like bodyClasses.
  • In behavior-durable-column in the existing quicksand-redraw listener, do document.body.className = new_data.bodyClasses or similar.
This revision was automatically updated to reflect the committed changes.