Page MenuHomePhabricator
Differential D16645

Revert "Clean up more Quicksand"
ClosedPublic
Actions

Authored by chad on Oct 1 2016, 7:36 PM.
Tags
None
Referenced Files
F18763068: D16645.id.diff
Mon, Oct 6, 10:26 PM
F18763064: D16645.id40073.diff
Mon, Oct 6, 10:25 PM
F18754444: D16645.id.diff
Sat, Oct 4, 11:05 PM
F18672349: D16645.id40072.diff
Thu, Sep 25, 7:21 AM
F18653728: D16645.diff
Sun, Sep 21, 3:52 PM
F18653474: D16645.diff
Sun, Sep 21, 1:52 PM
F18646898: D16645.id40073.diff
Fri, Sep 19, 11:29 AM
F18645030: D16645.diff
Fri, Sep 19, 6:48 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T11718: 2 scroll bars appear on all pages
Commits
rP87ebb80059f0: Revert "Clean up more Quicksand"
Summary

This reverts commit 5eb4bc6ca960aa0eafaa25591baea102ff4e034b.

Test Plan

Reload homepage, no scrollbars

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40072.Oct 1 2016, 7:36 PM
chad retitled this revision from to Revert "Clean up more Quicksand".
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 1 2016, 7:36 PM
epriestley accepted this revision.Oct 1 2016, 7:46 PM
epriestley edited edge metadata.

I think this approach is maybe slightly more promising, but your call.

This revision is now accepted and ready to land.Oct 1 2016, 7:46 PM
chad added a comment.Oct 1 2016, 7:47 PM

which approach? reverting and going with body classes or faking a background on all pages?

chad added a comment.Oct 1 2016, 7:49 PM

can I just pass body classes in via quicksand config?

chad added a comment.Oct 1 2016, 7:49 PM

i am just a corgi. javascript is hard.

epriestley added a comment.Oct 1 2016, 7:52 PM

Yes, I think.

  • Have buildQuicksandConfig() in PhabricatorStandardPageView include a key like bodyClasses.
  • In behavior-durable-column in the existing quicksand-redraw listener, do document.body.className = new_data.bodyClasses or similar.
Closed by commit rP87ebb80059f0: Revert "Clean up more Quicksand" (authored by chad, committed by chad). · Explain WhyOct 1 2016, 7:58 PM
This revision was automatically updated to reflect the committed changes.
Luke081515.2 added a task: T11718: 2 scroll bars appear on all pages.Oct 1 2016, 10:16 PM

Revision Contents
Changeset List

Diff 40073

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigAllController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigApplicationController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigCacheController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigClusterRepositoriesController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigGroupController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigHistoryController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIssueListController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIssueViewController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigListController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigModuleController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigVersionController.php

Loading...
View Options

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
View Options

webroot/rsrc/css/application/search/application-search-view.css

Loading...
View Options

webroot/rsrc/css/core/core.css

Loading...
View Options

webroot/rsrc/css/phui/phui-basic-nav-view.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workboard-color.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workboard.css

Loading...
Phabricator · Built by Phacility