Paths

Table of Contentst

Differential D16645

Revert "Clean up more Quicksand"
ClosedPublic
Actions

Authored by chad on Oct 1 2016, 7:36 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T11718: 2 scroll bars appear on all pages

Commits

rP87ebb80059f0: Revert "Clean up more Quicksand"

Summary

This reverts commit 5eb4bc6ca960aa0eafaa25591baea102ff4e034b.

Test Plan

Reload homepage, no scrollbars

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40072.Oct 1 2016, 7:36 PM

chad retitled this revision from to Revert "Clean up more Quicksand".

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 1 2016, 7:36 PM

I think this approach is maybe slightly more promising, but your call.

This revision is now accepted and ready to land.Oct 1 2016, 7:46 PM

which approach? reverting and going with body classes or faking a background on all pages?

can I just pass body classes in via quicksand config?

i am just a corgi. javascript is hard.

Yes, I think.

Have buildQuicksandConfig() in PhabricatorStandardPageView include a key like bodyClasses.
In behavior-durable-column in the existing quicksand-redraw listener, do document.body.className = new_data.bodyClasses or similar.

Closed by commit rP87ebb80059f0: Revert "Clean up more Quicksand" (authored by chad, committed by chad). · Explain WhyOct 1 2016, 7:58 PM

This revision was automatically updated to reflect the committed changes.

Luke081515.2 added a task: T11718: 2 scroll bars appear on all pages.Oct 1 2016, 10:16 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

26 lines

src/

applications/

config/

controller/

PhabricatorConfigAllController.php

2 lines

PhabricatorConfigApplicationController.php

2 lines

PhabricatorConfigCacheController.php

2 lines

PhabricatorConfigClusterDatabasesController.php

2 lines

PhabricatorConfigClusterNotificationsController.php

2 lines

PhabricatorConfigClusterRepositoriesController.php

2 lines

PhabricatorConfigDatabaseIssueController.php

2 lines

PhabricatorConfigDatabaseStatusController.php

2 lines

PhabricatorConfigGroupController.php

2 lines

PhabricatorConfigHistoryController.php

2 lines

PhabricatorConfigIssueListController.php

2 lines

PhabricatorConfigIssueViewController.php

2 lines

PhabricatorConfigListController.php

2 lines

PhabricatorConfigModuleController.php

2 lines

PhabricatorConfigVersionController.php

2 lines

home/

controller/

PhabricatorHomeMainController.php

2 lines

project/

controller/

PhabricatorProjectBoardViewController.php

4 lines

search/

controller/

PhabricatorApplicationSearchController.php

4 lines

view/

page/

PhabricatorStandardPageView.php

20 lines

webroot/

rsrc/

css/

application/

base/

standard-page-view.css

13 lines

search/

application-search-view.css

10 lines

core/

core.css

7 lines

phui/

phui-basic-nav-view.css

6 lines

workboards/

phui-workboard-color.css

4 lines

phui-workboard.css

9 lines

Diff 40073

View Options

resources/celerity/map.php

View Options

src/applications/config/controller/PhabricatorConfigAllController.php

View Options

src/applications/config/controller/PhabricatorConfigApplicationController.php

View Options

src/applications/config/controller/PhabricatorConfigCacheController.php

View Options

src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php

View Options

src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php

View Options

src/applications/config/controller/PhabricatorConfigClusterRepositoriesController.php

View Options

src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php

View Options

src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php

View Options

src/applications/config/controller/PhabricatorConfigGroupController.php

View Options

src/applications/config/controller/PhabricatorConfigHistoryController.php

View Options

src/applications/config/controller/PhabricatorConfigIssueListController.php

View Options

src/applications/config/controller/PhabricatorConfigIssueViewController.php

View Options

src/applications/config/controller/PhabricatorConfigListController.php

View Options

src/applications/config/controller/PhabricatorConfigModuleController.php

View Options

src/applications/config/controller/PhabricatorConfigVersionController.php

View Options

src/applications/home/controller/PhabricatorHomeMainController.php

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

View Options

src/view/page/PhabricatorStandardPageView.php

View Options

webroot/rsrc/css/application/base/standard-page-view.css

View Options

webroot/rsrc/css/application/search/application-search-view.css

View Options

webroot/rsrc/css/core/core.css

View Options

webroot/rsrc/css/phui/phui-basic-nav-view.css

View Options

webroot/rsrc/css/phui/workboards/phui-workboard-color.css

View Options

webroot/rsrc/css/phui/workboards/phui-workboard.css

Revert "Clean up more Quicksand"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40073

resources/celerity/map.php

src/applications/config/controller/PhabricatorConfigAllController.php

src/applications/config/controller/PhabricatorConfigApplicationController.php

src/applications/config/controller/PhabricatorConfigCacheController.php

src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php

src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php

src/applications/config/controller/PhabricatorConfigClusterRepositoriesController.php

src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php

src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php

src/applications/config/controller/PhabricatorConfigGroupController.php

src/applications/config/controller/PhabricatorConfigHistoryController.php

src/applications/config/controller/PhabricatorConfigIssueListController.php

src/applications/config/controller/PhabricatorConfigIssueViewController.php

src/applications/config/controller/PhabricatorConfigListController.php

src/applications/config/controller/PhabricatorConfigModuleController.php

src/applications/config/controller/PhabricatorConfigVersionController.php

src/applications/home/controller/PhabricatorHomeMainController.php

src/applications/project/controller/PhabricatorProjectBoardViewController.php

src/applications/search/controller/PhabricatorApplicationSearchController.php

src/view/page/PhabricatorStandardPageView.php

webroot/rsrc/css/application/base/standard-page-view.css

webroot/rsrc/css/application/search/application-search-view.css

webroot/rsrc/css/core/core.css

webroot/rsrc/css/phui/phui-basic-nav-view.css

webroot/rsrc/css/phui/workboards/phui-workboard-color.css

webroot/rsrc/css/phui/workboards/phui-workboard.css

Revert "Clean up more Quicksand"
ClosedPublic
Actions

Revision Contents
Changeset List