Page MenuHomePhabricator

Revert "Clean up more Quicksand"
ClosedPublic

Authored by chad on Oct 1 2016, 7:36 PM.

Details

Summary
Test Plan

Reload homepage, no scrollbars

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Revert "Clean up more Quicksand".
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

I think this approach is maybe slightly more promising, but your call.

This revision is now accepted and ready to land.Oct 1 2016, 7:46 PM

which approach? reverting and going with body classes or faking a background on all pages?

can I just pass body classes in via quicksand config?

i am just a corgi. javascript is hard.

Yes, I think.

  • Have buildQuicksandConfig() in PhabricatorStandardPageView include a key like bodyClasses.
  • In behavior-durable-column in the existing quicksand-redraw listener, do document.body.className = new_data.bodyClasses or similar.
This revision was automatically updated to reflect the committed changes.