Page MenuHomePhabricator

Revert "Clean up more Quicksand"

Authored by chad on Oct 1 2016, 7:36 PM.
Referenced Files
F12150166: D16645.diff
Sat, Sep 2, 4:34 PM
F12149242: D16645.id40073.diff
Sat, Sep 2, 8:12 AM
Fri, Sep 1, 1:07 PM
F12134971: D16645.id40072.diff
Aug 25 2023, 7:52 AM
Unknown Object (File)
Aug 8 2023, 1:02 PM
Unknown Object (File)
Jul 30 2023, 8:36 AM
Unknown Object (File)
Jul 29 2023, 10:07 PM
Unknown Object (File)
Jul 13 2023, 11:45 AM


Test Plan

Reload homepage, no scrollbars

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

chad retitled this revision from to Revert "Clean up more Quicksand".
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

I think this approach is maybe slightly more promising, but your call.

This revision is now accepted and ready to land.Oct 1 2016, 7:46 PM

which approach? reverting and going with body classes or faking a background on all pages?

can I just pass body classes in via quicksand config?

i am just a corgi. javascript is hard.

Yes, I think.

  • Have buildQuicksandConfig() in PhabricatorStandardPageView include a key like bodyClasses.
  • In behavior-durable-column in the existing quicksand-redraw listener, do document.body.className = new_data.bodyClasses or similar.
This revision was automatically updated to reflect the committed changes.