Differential D16622

Add RRULE support for SETPOS with FREQ=DAILY
ClosedPublic
Actions

Authored by epriestley on Sep 28 2016, 2:46 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHUf6424183c50e: Add RRULE support for SETPOS with FREQ=DAILY

Summary

Ref T10747. Most of these tests passed already.

Fix SETPOS with FREQ=DAILY and make that test pass too.

Test Plan

Unit tests now pass.

Diff Detail

Repository

rPHU libphutil

Branch

cal2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13901
Build 17994: Run Core Tests
Build 17993: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40013.Sep 28 2016, 2:46 PM

epriestley retitled this revision from to Add RRULE support for SETPOS with FREQ=DAILY.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 28 2016, 6:24 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 28 2016, 6:24 PM

Closed by commit rPHUf6424183c50e: Add RRULE support for SETPOS with FREQ=DAILY (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 10:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarRecurrenceRule.php

31 lines

__tests__/

PhutilCalendarRecurrenceRuleTestCase.php

71 lines

Diff 40013

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

View Options

src/parser/calendar/data/tests/PhutilCalendarRecurrenceRuleTestCase.php

Add RRULE support for SETPOS with FREQ=DAILYClosedPublicActions