Differential D16619

Fix an RRULE bug with day cursors and skipped months
ClosedPublic
Actions

Authored by epriestley on Sep 28 2016, 2:32 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU83e9aaa17832: Fix an RRULE bug with day cursors and skipped months

Summary

Ref T10747. This rule wasn't quite correct, and got some things like BYMONTH=1,3;INTERVAL=9 wrong.

Instead of resetting the day cursor to 1, we need to move it forward through time in INTERVAL jumps until we get to the next candidate month.

Test Plan

Unit tests now pass.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40010.Sep 28 2016, 2:32 PM

epriestley retitled this revision from to Fix an RRULE bug with day cursors and skipped months.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 28 2016, 6:24 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 28 2016, 6:24 PM

Closed by commit rPHU83e9aaa17832: Fix an RRULE bug with day cursors and skipped months (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 10:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarRecurrenceRule.php

64 lines

__tests__/

PhutilCalendarRecurrenceRuleTestCase.php

63 lines

Diff 40021

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

View Options

src/parser/calendar/data/tests/PhutilCalendarRecurrenceRuleTestCase.php

Fix an RRULE bug with day cursors and skipped monthsClosedPublicActions