Page MenuHomePhabricator
Differential D16598

Fix a bug in the imageproxy controller
ClosedPublic
Actions

Authored by jcox on Sep 26 2016, 2:18 PM.
Tags
None
Referenced Files
F14395219: D16598.diff
Sun, Dec 22, 3:40 AM
F14392706: D16598.diff
Sat, Dec 21, 10:35 PM
F14387707: D16598.id.diff
Sat, Dec 21, 3:08 PM
Unknown Object (File)
Thu, Dec 19, 1:07 PM
Unknown Object (File)
Tue, Dec 17, 3:59 AM
Unknown Object (File)
Sat, Dec 14, 1:11 PM
Unknown Object (File)
Sat, Dec 7, 12:49 AM
Unknown Object (File)
Thu, Dec 5, 5:09 AM
View All Files
Subscribers
epriestley
yelirekim
Tokens
"Hungry Hippo" token, awarded by epriestley."Dislike" token, awarded by jcox.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rP7d576c3f94b5: Fix a bug in the imageproxy controller
Summary

Somehow this got through last week :( It's a bug that causes the controller to... *ahem*... just not work. Luckily nothing uses this yet so nothing was really affected.

Test Plan

Hit /file/imageproxy/?uri=http://i.imgur.com/nTvVrYN.jpg and are served a nice picture of a bird

Diff Detail

Repository
rP Phabricator
Branch
ProxyControllerTypoFix
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13839
Build 17894: Run Core Tests
Build 17893: arc lint + arc unit

Event Timeline

jcox updated this revision to Diff 39950.Sep 26 2016, 2:18 PM
jcox retitled this revision from to Fix a bug in the imageproxy controller.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 26 2016, 2:18 PM
Herald added subscribers: yelirekim, epriestley. · View Herald Transcript
jcox updated this object.Sep 26 2016, 2:19 PM
jcox edited the test plan for this revision. (Show Details)
jcox edited edge metadata.
jcox awarded a token.Sep 26 2016, 2:25 PM
epriestley accepted this revision.Sep 26 2016, 2:35 PM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Sep 26 2016, 2:35 PM
epriestley awarded a token.Sep 26 2016, 2:35 PM
Closed by commit rP7d576c3f94b5: Fix a bug in the imageproxy controller (authored by jcox, committed by jcox). · Explain WhySep 26 2016, 2:55 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11701: Add a lint rule for `if (CONSTANT) { ... }`.Sep 26 2016, 3:12 PM

Revision Contents
Changeset List

PathSize
src/
applications/
files/
controller/
2 lines

Diff 39950

View Options

src/applications/files/controller/PhabricatorFileImageProxyController.php

Loading...
Phabricator · Built by Phacility