Page MenuHomePhabricator

Add a specialized cache for storing "has setup ever worked?"
ClosedPublic

Authored by epriestley on Sep 12 2016, 2:36 PM.
Tags
None
Referenced Files
F18982634: D16542.diff
Mon, Nov 17, 7:10 AM
F18938657: D16542.diff
Tue, Nov 11, 4:39 AM
F18886570: D16542.id.diff
Fri, Nov 7, 4:34 AM
F18867956: D16542.diff
Tue, Nov 4, 3:47 AM
F18854167: D16542.diff
Fri, Oct 31, 10:03 PM
F18807819: D16542.diff
Sun, Oct 19, 3:29 AM
F18798912: D16542.id39807.diff
Oct 17 2025, 9:53 AM
F18790924: D16542.diff
Oct 15 2025, 9:04 PM
Subscribers
None

Details

Summary

Ref T11613. In D16503/T11598 I refined the setup flow to improve messaging for early-stage setup issues, but failed to fully untangle things.

We sometimes still try to access a cache which uses configuration before we build configuration, which causes an error.

Instead, store "are we in flight / has setup ever worked?" in a separate cache which doesn't use the cache namespace. This stops us from trying to read config before building config.

Test Plan

Hit bad extension error with a fake extension, got a proper setup help page:

Screen Shot 2016-09-12 at 7.30.45 AM.png (1×1 px, 137 KB)

Solved the error, reloaded, broke things again, got a "friendly" page:

Screen Shot 2016-09-12 at 7.31.19 AM.png (1×1 px, 66 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add a specialized cache for storing "has setup ever worked?".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 12 2016, 3:03 PM
src/infrastructure/env/PhabricatorEnv.php
326–332

(I moved these down to avoid an error on the call to array_key_exists() where $cache might not exist yet.)

This revision was automatically updated to reflect the committed changes.