Show broken units in revision history
ClosedPublic
Actions

Authored by avivey on Sep 2 2016, 1:29 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rP31c5f39506bd: Show broken units in revision history

Summary

This is hacky, and I'm not sure I'm happy with it; Until T9365 is done, this will show up
broken tests with an appropriate star in the Revision History.

Test Plan

Created 1M messages in a couple of old diffs in a revision. The query took ~80us (On SSD drive).

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey updated this revision to Diff 39658.Sep 2 2016, 1:29 AM

avivey retitled this revision from to Show broken units in revision history.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 2 2016, 1:29 AM

Herald added a subscriber: epriestley. · View Herald Transcript

stray debug string

Cool, I think this is pretty reasonable. Thanks!

(For context for anyone else reading this: this is a compromise to improve integration of Harbormaster unit test data in the short term, until we can fix this properly in D16417 or similar, but that requires more planning through T9365/T10635/T11402 than I want to do right away.)

It looks like there's no <buildTargetPHID, result> key on the harbormaster_buildunitmessage table so this might still need to look at a fair number of rows, but it shouldn't need to load them so I don't think it will make T10635 materially worse. We can keep an eye on it; I have more of an idea of how I want to attack that than of how I want to do aggregation.