Differential D16444

Added high security requirement to add/delete email addresses
ClosedPublic
Actions

Authored by jcox on Aug 24 2016, 9:09 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10999: Expand MFA checks to all email operations

Commits

rPa1f25fdb3e63: Added high security requirement to add/delete email addresses

Summary

Fixes T10999. Now MFA will be required for all email address related operations.

Test Plan

Ensure that adding and removing email addresses now requires you to enter high security mode.

Diff Detail

Repository

rP Phabricator

Branch

MFAForAllEmailOps (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13425
Build 17245: Run Core Tests
Build 17244: arc lint + arc unit

Event Timeline

jcox updated this revision to Diff 39549.Aug 24 2016, 9:09 PM

jcox retitled this revision from to Added high security requirement to add/delete email addresses.

jcox updated this object.

jcox edited the test plan for this revision. (Show Details)

jcox added a task: T10999: Expand MFA checks to all email operations.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 24 2016, 9:09 PM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley accepted this revision.Aug 24 2016, 10:49 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.Aug 24 2016, 10:49 PM

Closed by commit rPa1f25fdb3e63: Added high security requirement to add/delete email addresses (authored by jcox, committed by jcox). · Explain WhyAug 25 2016, 1:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

panel/

PhabricatorEmailAddressesSettingsPanel.php

10 lines

Diff 39549

View Options

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php

Added high security requirement to add/delete email addressesClosedPublicActions