Page MenuHomePhabricator
Differential D16421

Fix getIcon calls in PHUIObjectListItem
ClosedPublic
Actions

Authored by chad on Aug 19 2016, 4:31 PM.
Tags
None
Referenced Files
F15450466: D16421.diff
Fri, Mar 28, 3:50 PM
F15436478: D16421.id39490.diff
Tue, Mar 25, 2:30 PM
F15388202: D16421.diff
Sat, Mar 15, 3:28 AM
F15386792: D16421.id39490.diff
Sat, Mar 15, 1:18 AM
F15385154: D16421.id39489.diff
Fri, Mar 14, 9:52 PM
F15367725: D16421.id39489.diff
Tue, Mar 11, 8:48 PM
Unknown Object (File)
Feb 18 2025, 11:36 AM
Unknown Object (File)
Feb 9 2025, 2:11 AM
View All Files
Subscribers
Korvin
Restricted Owners Package

Details

Reviewers
epriestley
Maniphest Tasks
T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView
Commits
rPe7aa874f5eba: Fix getIcon calls in PHUIObjectListItem
Summary

Fixes T11501. Let's you pass in a full PHUIIconView or just the icon name to give ObjectListItem a large icon.

Test Plan

Alamanac, Applications, Drydock, Settings, Search Typeahead, Config page...

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/settings/query/PhabricatorUserPreferencesSearchEngine.php:68XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 13364
Build 17149: Run Core Tests
Build 17148: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39489.Aug 19 2016, 4:31 PM
chad retitled this revision from to Fix getIcon calls in PHUIObjectListItem.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView.
Owners added a subscriber: Restricted Owners Package.Aug 19 2016, 4:31 PM
Herald added a subscriber: Korvin. · View Herald TranscriptAug 19 2016, 4:31 PM
epriestley accepted this revision.Aug 19 2016, 4:34 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 19 2016, 4:34 PM
Closed by commit rPe7aa874f5eba: Fix getIcon calls in PHUIObjectListItem (authored by chad, committed by chad). · Explain WhyAug 19 2016, 4:34 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Aug 19 2016, 4:34 PM

prolly go ahead and roll server in case I missed anything else?

epriestley added a comment.Aug 19 2016, 5:18 PM

Sure, coming up in a sec...

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
controller/
10 lines
config/
controller/
2 lines
drydock/
controller/
8 lines
meta/
query/
14 lines
settings/
query/
4 lines
view/
phui/
9 lines

Diff 39489

View Options

src/applications/almanac/controller/AlmanacConsoleController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigListController.php

Loading...
View Options

src/applications/drydock/controller/DrydockConsoleController.php

Loading...
View Options

src/applications/meta/query/PhabricatorAppSearchEngine.php

Loading...
View Options

src/applications/settings/query/PhabricatorUserPreferencesSearchEngine.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
Phabricator · Built by Phacility