Page MenuHomePhabricator

Provide "--output" flags for "bin/storage renamespace"
ClosedPublic

Authored by epriestley on Aug 17 2016, 3:12 PM.
Tags
None
Referenced Files
F18623695: D16410.diff
Mon, Sep 15, 4:58 PM
F18585354: D16410.id39468.diff
Thu, Sep 11, 3:12 PM
F18583151: D16410.diff
Thu, Sep 11, 9:39 AM
F18580114: D16410.id39468.diff
Thu, Sep 11, 2:24 AM
F18579868: D16410.diff
Thu, Sep 11, 2:02 AM
F18507988: D16410.id.diff
Fri, Sep 5, 2:33 AM
F18114040: D16410.id39468.diff
Aug 13 2025, 3:29 AM
F18112773: D16410.id.diff
Aug 12 2025, 8:27 PM
Subscribers
None

Details

Summary

Ref T6996. Depends on D16407. This does the same stuff as D16407, but for bin/storage renamespace. In particular:

  • Support writing directly to a file (so we can get good errors on failure).
  • Support in-process compression.

Also add support for reading out of a storage dump subprocess, so we don't have to do a dump-to-disk + renamespace + compress dance and can just stream out of MySQL directly to a compressed file on disk.

This is used in the second stage of instance exports (see T7148).

It would be nice to share more code with bin/storage dump, and possibly to just make this a flag for it, although we still do need to do the file-based version when importing (vs exporting). I figured that was better left for another time.

Test Plan

Ran bin/storage renamespace --live --output x --from A --to B --compress --overwrite and similar commands.

Verified that a compressed, renamespaced dump came out of the other end.

Diff Detail

Repository
rP Phabricator
Branch
dumpx2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13341
Build 17116: Run Core Tests
Build 17115: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Provide "--output" flags for "bin/storage renamespace".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 17 2016, 3:55 PM
This revision was automatically updated to reflect the committed changes.