Page MenuHomePhabricator

Provide "--output" flags for "bin/storage renamespace"
ClosedPublic

Authored by epriestley on Aug 17 2016, 3:12 PM.
Tags
None
Referenced Files
F13083548: D16410.diff
Wed, Apr 24, 10:38 PM
Unknown Object (File)
Sat, Apr 20, 7:47 PM
Unknown Object (File)
Mon, Apr 8, 10:25 PM
Unknown Object (File)
Thu, Apr 4, 6:50 AM
Unknown Object (File)
Tue, Apr 2, 4:42 AM
Unknown Object (File)
Sat, Mar 30, 2:34 AM
Unknown Object (File)
Feb 18 2024, 2:48 PM
Unknown Object (File)
Feb 15 2024, 5:42 PM
Subscribers
None

Details

Summary

Ref T6996. Depends on D16407. This does the same stuff as D16407, but for bin/storage renamespace. In particular:

  • Support writing directly to a file (so we can get good errors on failure).
  • Support in-process compression.

Also add support for reading out of a storage dump subprocess, so we don't have to do a dump-to-disk + renamespace + compress dance and can just stream out of MySQL directly to a compressed file on disk.

This is used in the second stage of instance exports (see T7148).

It would be nice to share more code with bin/storage dump, and possibly to just make this a flag for it, although we still do need to do the file-based version when importing (vs exporting). I figured that was better left for another time.

Test Plan

Ran bin/storage renamespace --live --output x --from A --to B --compress --overwrite and similar commands.

Verified that a compressed, renamespaced dump came out of the other end.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Provide "--output" flags for "bin/storage renamespace".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 17 2016, 3:55 PM
This revision was automatically updated to reflect the committed changes.