Fixes T11416. Unclear what the side-effects of this would be, so bark if you find something. Previously, we'd have to overflow and scroll, which is kind of a pain since you're hiding content on long code blocks. This just wraps long lines, and preserves line breaks globally.
Details
Details
- Reviewers
epriestley avivey - Maniphest Tasks
- T11416: fixed-width-text remarkup blocks lost max-width
- Commits
- rP0bb5dd88c87d: Always pre-wrap code blocks
Test feed, profile, comments, inline comments, triple backticks.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- triple-backtick (branched from master)
- Lint
Lint Skipped - Unit
No Test Coverage - Build Status
Buildable 13230 Build 16954: Run Core Tests Build 16953: arc lint + arc unit
Event Timeline
Comment Actions
This is what I get with this patch:
ie, it get's line-wrapped, which I think is not the desired behavior in case this is code?
I was also expecting "pre-wrap" to not actually do this, but that's probably just me.
Comment Actions
That's what I expect you to get with this patch. We have two choices:
- hide content
- wrap content
I went with wrap, so users don't have to scroll.
Comment Actions
I think the desired behvior is "keep the line breaks exactly as typed, but limit the actual space used for this block and add scrollbars if needed".
Comment Actions
ok; I'd have gone with hiding, but I'll defer this to your expertise.
about the jshint, do you have v2.7.0 installed? We break kinda poorly on some other versions.
Comment Actions
I can't come up with any likely issues offhand.
I agree that this behavior is the best one available to us in most cases.