Page MenuHomePhabricator
Differential D16357

Add a lint error about use of PHP short array syntax ('[...]')
ClosedPublic
Actions

Authored by epriestley on Aug 1 2016, 11:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 4:08 PM
Unknown Object (File)
Tue, May 7, 7:10 AM
Unknown Object (File)
Sun, May 5, 6:08 AM
Unknown Object (File)
Fri, May 3, 5:20 AM
Unknown Object (File)
Mon, Apr 29, 5:15 PM
Unknown Object (File)
Sun, Apr 28, 7:37 PM
Unknown Object (File)
Thu, Apr 25, 12:51 AM
Unknown Object (File)
Fri, Apr 19, 5:10 PM
View All Files
Subscribers
None

Details

Reviewers
yelirekim
chad
Maniphest Tasks
T11409: harbormaster.buildquery fatals on short array syntax in older PHP
Commits
rARCf20d4b15c7e4: Add a lint error about use of PHP short array syntax ('[...]')
Summary

Ref T11409. Add lint to detect using [...] to define arrays. This doesn't work in PHP 5.2/5.3, which some of our users run.

Test Plan
  • Ran arc unit.
  • Ran arc lint src/applications/harbormaster/conduit/HarbormasterQueryBuildsConduitAPIMethod.php to detect the issue in T11409.

Diff Detail

Repository
rARC Arcanist
Branch
shortarray
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13219
Build 16936: Run Core Tests
Build 16935: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39339.Aug 1 2016, 11:26 AM
epriestley retitled this revision from to Add a lint error about use of PHP short array syntax ('[...]').
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, yelirekim.
epriestley added a task: T11409: harbormaster.buildquery fatals on short array syntax in older PHP.
chad accepted this revision.Aug 1 2016, 2:22 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2016, 2:22 PM
Closed by commit rARCf20d4b15c7e4: Add a lint error about use of PHP short array syntax ('[...]') (authored by epriestley, committed by epriestley). · Explain WhyAug 1 2016, 5:45 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11451: Threaded comments.Aug 10 2016, 3:29 PM

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
xhpast/
rules/
13 lines
__tests__/
php-compatibility/
3 lines

Diff 39339

View Options

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/php-compatibility/php54-features.lint-test

Loading...
Phabricator · Built by Phacility