Page MenuHomePhabricator
Differential D16333

Remove command spelling correction from Arcanist
ClosedPublic
Actions

Authored by epriestley on Jul 27 2016, 12:41 PM.
Tags
None
Referenced Files
F13051792: D16333.diff
Fri, Apr 19, 4:37 AM
F13047911: D16333.id39270.diff
Thu, Apr 18, 2:52 PM
Unknown Object (File)
Tue, Apr 16, 11:21 AM
Unknown Object (File)
Wed, Apr 10, 5:00 PM
Unknown Object (File)
Sun, Apr 7, 5:07 AM
Unknown Object (File)
Sun, Mar 31, 6:36 AM
Unknown Object (File)
Fri, Mar 29, 3:45 AM
Unknown Object (File)
Jan 6 2024, 2:24 AM
View All 88 Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7489: Move argument spelling correction to PhutilArgumentWorkflow
Commits
rARC06c641f92c65: Remove command spelling correction from Arcanist
Summary

Fixes T7489. Depends on D16332, which moved this code to libphutil.

Test Plan
$ arc banch --bystatus
(Assuming 'banch' is the British spelling of 'branch'.)
(Assuming '--bystatus' is the British spelling of '--by-status'.)
...

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39270.Jul 27 2016, 12:41 PM
epriestley retitled this revision from to Remove command spelling correction from Arcanist.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7489: Move argument spelling correction to PhutilArgumentWorkflow.
epriestley updated this object.Jul 27 2016, 12:41 PM
epriestley added a parent revision: D16332: Move command spelling correction to libphutil.
epriestley mentioned this in T7489: Move argument spelling correction to PhutilArgumentWorkflow.Jul 27 2016, 12:46 PM
chad accepted this revision.Jul 27 2016, 3:40 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 27 2016, 3:40 PM
Closed by commit rARC06c641f92c65: Remove command spelling correction from Arcanist (authored by epriestley, committed by epriestley). · Explain WhyJul 27 2016, 4:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
configuration/
77 lines
__tests__/
workflow/
5 lines

Diff 39278

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/configuration/ArcanistConfiguration.php

Loading...
View Options

src/configuration/__tests__/ArcanistBritishTestCase.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility