Page MenuHomePhabricator
Differential D16333

Remove command spelling correction from Arcanist
ClosedPublic
Actions

Authored by epriestley on Jul 27 2016, 12:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 7:01 PM
Unknown Object (File)
Tue, Nov 19, 10:36 AM
Unknown Object (File)
Fri, Nov 15, 3:45 AM
Unknown Object (File)
Mon, Nov 11, 2:28 PM
Unknown Object (File)
Mon, Nov 11, 1:59 AM
Unknown Object (File)
Thu, Nov 7, 3:47 AM
Unknown Object (File)
Sun, Oct 27, 11:29 AM
Unknown Object (File)
Sep 24 2024, 3:26 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7489: Move argument spelling correction to PhutilArgumentWorkflow
Commits
rARC06c641f92c65: Remove command spelling correction from Arcanist
Summary

Fixes T7489. Depends on D16332, which moved this code to libphutil.

Test Plan
$ arc banch --bystatus
(Assuming 'banch' is the British spelling of 'branch'.)
(Assuming '--bystatus' is the British spelling of '--by-status'.)
...

Diff Detail

Repository
rARC Arcanist
Branch
console2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13146
Build 16823: Run Core Tests
Build 16822: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39270.Jul 27 2016, 12:41 PM
epriestley retitled this revision from to Remove command spelling correction from Arcanist.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7489: Move argument spelling correction to PhutilArgumentWorkflow.
epriestley updated this object.Jul 27 2016, 12:41 PM
epriestley added a parent revision: D16332: Move command spelling correction to libphutil.
epriestley mentioned this in T7489: Move argument spelling correction to PhutilArgumentWorkflow.Jul 27 2016, 12:46 PM
chad accepted this revision.Jul 27 2016, 3:40 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 27 2016, 3:40 PM
Closed by commit rARC06c641f92c65: Remove command spelling correction from Arcanist (authored by epriestley, committed by epriestley). · Explain WhyJul 27 2016, 4:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
configuration/
77 lines
__tests__/
workflow/
5 lines

Diff 39270

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/configuration/ArcanistConfiguration.php

Loading...
View Options

src/configuration/__tests__/ArcanistBritishTestCase.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility