Page MenuHomePhabricator
Differential D16317

bin/storage shell: force TCP
ClosedPublic
Actions

Authored by avivey on Jul 21 2016, 10:12 PM.
Tags
None
Referenced Files
F14054312: D16317.diff
Fri, Nov 15, 11:57 PM
F14031854: D16317.id39238.diff
Sat, Nov 9, 12:04 PM
F14031853: D16317.id39237.diff
Sat, Nov 9, 12:04 PM
F14031852: D16317.id.diff
Sat, Nov 9, 12:04 PM
F14019695: D16317.diff
Tue, Nov 5, 11:28 PM
F14012595: D16317.diff
Fri, Nov 1, 2:52 PM
F14011269: D16317.diff
Thu, Oct 31, 10:19 PM
F13982212: D16317.diff
Sat, Oct 19, 9:53 PM
View All Files
Subscribers
fooishbar
Korvin

Details

Reviewers
joshuaspence
epriestley
Group Reviewers
Blessed Reviewers
Commits
rP68904d941c54: bin/storage shell: force TCP
Summary

mysql has the magic feature of ignoring port arguments and using the socket when connecting to localhost.

This flag makes it not do that.

Test Plan

./bin/storage shell, execute status, see Connection: localhost via TCP/IP.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13114
Build 16772: Run Core Tests
Build 16771: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 39237.Jul 21 2016, 10:12 PM
avivey retitled this revision from to bin/storage shell: force TCP.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added reviewers: epriestley, joshuaspence.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 21 2016, 10:12 PM
Herald added a subscriber: Korvin. · View Herald Transcript
avivey updated this object.Jul 21 2016, 10:13 PM
avivey edited edge metadata.
epriestley accepted this revision.Jul 21 2016, 11:17 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 21 2016, 11:17 PM
Closed by commit rP68904d941c54: bin/storage shell: force TCP (authored by avivey, committed by avivey). · Explain WhyJul 21 2016, 11:42 PM
This revision was automatically updated to reflect the committed changes.
fooishbar added a subscriber: fooishbar.Aug 1 2016, 11:19 AM

@avivey: Is there any particular rationale to doing this? I'm looking at going in the other direction - completely away from TCP - and this makes that somewhat harder ...

avivey added a comment.Aug 1 2016, 6:01 PM

The rational is, phabricator is always connecting via tcp, and the settings might be different (eg: user might not have permissions) when connecting via socket.

fooishbar added a comment.Aug 3 2016, 12:54 PM

@avivey Reasonable enough. I'd hoped to be able to use socket paths explicitly, but that would be a separate change to this then. Thanks, and sorry for the noise.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
storage/
management/
workflow/
2 lines

Diff 39237

View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementShellWorkflow.php

Loading...
Phabricator · Built by Phacility