Page MenuHomePhabricator

bin/storage shell: force TCP
ClosedPublic

Authored by avivey on Jul 21 2016, 10:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 28, 1:42 PM
Unknown Object (File)
Tue, May 27, 11:21 AM
Unknown Object (File)
Sun, May 25, 9:47 PM
Unknown Object (File)
Sat, May 10, 1:45 PM
Unknown Object (File)
Sat, May 10, 8:46 AM
Unknown Object (File)
Wed, May 7, 9:13 PM
Unknown Object (File)
Fri, May 2, 9:09 AM
Unknown Object (File)
Apr 29 2025, 1:52 AM
Subscribers

Details

Summary

mysql has the magic feature of ignoring port arguments and using the socket when connecting to localhost.

This flag makes it not do that.

Test Plan

./bin/storage shell, execute status, see Connection: localhost via TCP/IP.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey retitled this revision from to bin/storage shell: force TCP.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added reviewers: epriestley, joshuaspence.
avivey edited edge metadata.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 21 2016, 11:17 PM
This revision was automatically updated to reflect the committed changes.

@avivey: Is there any particular rationale to doing this? I'm looking at going in the other direction - completely away from TCP - and this makes that somewhat harder ...

The rational is, phabricator is always connecting via tcp, and the settings might be different (eg: user might not have permissions) when connecting via socket.

@avivey Reasonable enough. I'd hoped to be able to use socket paths explicitly, but that would be a separate change to this then. Thanks, and sorry for the noise.