Paths

Table of Contentst

Differential D16317

bin/storage shell: force TCP
ClosedPublic
Actions

Authored by avivey on Jul 21 2016, 10:12 PM.

Tags

None

Referenced Files

	F15415954: D16317.diff
	Thu, Mar 20, 8:32 AM

	F15407729: D16317.id39237.diff
	Tue, Mar 18, 7:11 PM

	F15387162: D16317.id.diff
	Sat, Mar 15, 1:55 AM

	F15386468: D16317.id39237.diff
	Sat, Mar 15, 12:39 AM

	Unknown Object (File)
	Feb 20 2025, 11:36 AM

	Unknown Object (File)
	Feb 16 2025, 7:08 AM

	Unknown Object (File)
	Feb 13 2025, 8:16 PM

	Unknown Object (File)
	Feb 9 2025, 2:03 AM

Subscribers

Details

Reviewers

joshuaspence
epriestley

Group Reviewers

Blessed Reviewers

Commits

rP68904d941c54: bin/storage shell: force TCP

Summary

mysql has the magic feature of ignoring port arguments and using the socket when connecting to localhost.

This flag makes it not do that.

Test Plan

./bin/storage shell, execute status, see Connection: localhost via TCP/IP.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey updated this revision to Diff 39237.Jul 21 2016, 10:12 PM

avivey retitled this revision from to bin/storage shell: force TCP.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added reviewers: epriestley, joshuaspence.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 21 2016, 10:12 PM

Herald added a subscriber: Korvin. · View Herald Transcript

avivey updated this object.Jul 21 2016, 10:13 PM

avivey edited edge metadata.

epriestley accepted this revision.Jul 21 2016, 11:17 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 21 2016, 11:17 PM

Closed by commit rP68904d941c54: bin/storage shell: force TCP (authored by avivey, committed by avivey). · Explain WhyJul 21 2016, 11:42 PM

This revision was automatically updated to reflect the committed changes.

@avivey: Is there any particular rationale to doing this? I'm looking at going in the other direction - completely away from TCP - and this makes that somewhat harder ...

The rational is, phabricator is always connecting via tcp, and the settings might be different (eg: user might not have permissions) when connecting via socket.

@avivey Reasonable enough. I'd hoped to be able to use socket paths explicitly, but that would be a separate change to this then. Thanks, and sorry for the noise.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

storage/

management/

workflow/

PhabricatorStorageManagementShellWorkflow.php

2 lines

Diff 39238

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementShellWorkflow.php

Loading...