Page MenuHomePhabricator
Differential D16264

Move more event fields to EditEngine
ClosedPublic
Actions

Authored by epriestley on Jul 9 2016, 4:21 PM.
Tags
None
Referenced Files
F15533797: D16264.diff
Wed, Apr 23, 10:06 PM
F15516311: D16264.id39125.diff
Fri, Apr 18, 5:58 PM
F15492758: D16264.id39125.diff
Sat, Apr 12, 6:01 PM
F15454932: D16264.id39164.diff
Sat, Mar 29, 9:20 PM
F15450139: D16264.id39125.diff
Fri, Mar 28, 2:14 PM
F15449281: D16264.id.diff
Fri, Mar 28, 9:15 AM
F15443329: D16264.diff
Thu, Mar 27, 3:46 AM
F15421415: D16264.diff
Mar 21 2025, 11:32 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9275: Move Calendar to EditEngine
Commits
rPffdb9f06f859: Move more event fields to EditEngine
Summary

Ref T9275. This moves description, icon, and cancel/uncancel to EditEngine.

It removes TYPE_SEQUENCE_INDEX and TYPE_INSTANCE_OF_EVENT. These are currently never generated and I do not expect to genereate them (instead, these changes happen automatically when you edit a stub).

Test Plan

Edited an event with normal and pro edit forms.

Diff Detail

Repository
rP Phabricator
Branch
calendar3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13003
Build 16612: Run Core Tests
Build 16611: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39125.Jul 9 2016, 4:21 PM
epriestley retitled this revision from to Move more event fields to EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9275: Move Calendar to EditEngine.
chad accepted this revision.Jul 9 2016, 5:32 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2016, 5:32 PM
thoughtpolice mentioned this in T11305: 'View Options' in Differential reviews is badly aligned on narrow mobile screens.Jul 9 2016, 6:04 PM
Closed by commit rPffdb9f06f859: Move more event fields to EditEngine (authored by epriestley, committed by epriestley). · Explain WhyJul 13 2016, 2:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
editor/
33 lines
21 lines
storage/
15 lines

Diff 39125

View Options

src/applications/calendar/editor/PhabricatorCalendarEditEngine.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php

Loading...
Phabricator · Built by Phacility