Page MenuHomePhabricator
Differential D16264

Move more event fields to EditEngine
ClosedPublic
Actions

Authored by epriestley on Jul 9 2016, 4:21 PM.
Tags
None
Referenced Files
F18050433: D16264.id39125.diff
Sun, Aug 3, 7:44 PM
F17954481: D16264.diff
Fri, Aug 1, 4:05 AM
Unknown Object (File)
Jul 3 2025, 7:35 PM
Unknown Object (File)
Jun 1 2025, 7:45 AM
Unknown Object (File)
May 31 2025, 2:34 AM
Unknown Object (File)
May 27 2025, 11:19 AM
Unknown Object (File)
May 6 2025, 9:21 AM
Unknown Object (File)
Apr 30 2025, 12:15 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9275: Move Calendar to EditEngine
Commits
rPffdb9f06f859: Move more event fields to EditEngine
Summary

Ref T9275. This moves description, icon, and cancel/uncancel to EditEngine.

It removes TYPE_SEQUENCE_INDEX and TYPE_INSTANCE_OF_EVENT. These are currently never generated and I do not expect to genereate them (instead, these changes happen automatically when you edit a stub).

Test Plan

Edited an event with normal and pro edit forms.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39125.Jul 9 2016, 4:21 PM
epriestley retitled this revision from to Move more event fields to EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9275: Move Calendar to EditEngine.
chad accepted this revision.Jul 9 2016, 5:32 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2016, 5:32 PM
thoughtpolice mentioned this in T11305: 'View Options' in Differential reviews is badly aligned on narrow mobile screens.Jul 9 2016, 6:04 PM
Closed by commit rPffdb9f06f859: Move more event fields to EditEngine (authored by epriestley, committed by epriestley). · Explain WhyJul 13 2016, 2:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
editor/
33 lines
21 lines
storage/
15 lines

Diff 39164

View Options

src/applications/calendar/editor/PhabricatorCalendarEditEngine.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php

Loading...
Phabricator · Built by Phacility