Page MenuHomePhabricator

Move more event fields to EditEngine
ClosedPublic

Authored by epriestley on Jul 9 2016, 4:21 PM.
Tags
None
Referenced Files
F10890577: D16264.id39164.diff
Sun, Jul 3, 6:53 AM
Unknown Object (File)
Wed, Jun 15, 4:38 AM
Unknown Object (File)
Fri, Jun 10, 5:58 AM
Unknown Object (File)
Mon, Jun 6, 4:29 PM
Unknown Object (File)
May 23 2022, 2:16 AM
Unknown Object (File)
Apr 4 2017, 11:07 PM
Unknown Object (File)
Mar 10 2017, 8:51 PM
Unknown Object (File)
Mar 8 2017, 2:57 AM
Subscribers
None

Details

Summary

Ref T9275. This moves description, icon, and cancel/uncancel to EditEngine.

It removes TYPE_SEQUENCE_INDEX and TYPE_INSTANCE_OF_EVENT. These are currently never generated and I do not expect to genereate them (instead, these changes happen automatically when you edit a stub).

Test Plan

Edited an event with normal and pro edit forms.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Move more event fields to EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2016, 5:32 PM
This revision was automatically updated to reflect the committed changes.