Paths

Table of Contentst

Differential D16260

Fix "\" keyboard shortcut on German keyboard layouts
ClosedPublic
Actions

Authored by epriestley on Jul 8 2016, 3:32 PM.

Details

Reviewers

chad

Maniphest Tasks

T10252: Username autocompletion doesn't work with some non-US keyboard layouts

Commits

rP444e353700fa: Fix "\" keyboard shortcut on German keyboard layouts

Summary

Ref T10252. This is similar to D16259, but makes KeyboardShortcutManager more relaxed about altKey when typing obscure characters.

Test Plan

Pressed Option + Shift + 7 on a German keyboard layout, saw Conphernece sidebar toggle.

Diff Detail

Repository

rP Phabricator

Branch

layout2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12984
Build 16583: Run Core Tests
Build 16582: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39110.Jul 8 2016, 3:32 PM

epriestley retitled this revision from to Fix "\" keyboard shortcut on German keyboard layouts.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10252: Username autocompletion doesn't work with some non-US keyboard layouts.

chad accepted this revision.Jul 8 2016, 3:39 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 8 2016, 3:39 PM

Closed by commit rP444e353700fa: Fix "\" keyboard shortcut on German keyboard layouts (authored by epriestley, committed by epriestley). · Explain WhyJul 8 2016, 3:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

20 lines

webroot/

rsrc/

js/

core/

KeyboardShortcutManager.js

24 lines

Diff 39110

View Options

resources/celerity/map.php