Page MenuHomePhabricator

add renderValue() in transactions
ClosedPublic

Authored by avivey on Jul 8 2016, 12:12 AM.
Tags
None
Referenced Files
F17668642: D16252.diff
Sat, Jul 12, 11:18 PM
Unknown Object (File)
Jun 1 2025, 12:27 AM
Unknown Object (File)
May 30 2025, 9:13 PM
Unknown Object (File)
May 29 2025, 10:19 PM
Unknown Object (File)
May 10 2025, 12:23 PM
Unknown Object (File)
May 8 2025, 11:24 AM
Unknown Object (File)
Apr 30 2025, 12:54 AM
Unknown Object (File)
Apr 28 2025, 10:07 AM
Subscribers

Details

Summary

fix T11290.

Test Plan

Paste language type, view in web and in emails (It uses quotes in HTML emails, which I think is something else).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey retitled this revision from to add renderValue() in transactions.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added reviewers: chad, epriestley.

I'll let @chad pull the trigger on this one, but looks good to me.

The blinking may not be fast enough to sufficiently harm/annoy users.

avivey edited edge metadata.

Remove blink

actually I'd probably italicize/darken it over bold. how does it look?

bold:

pasted_file (154×297 px, 16 KB)

italic + black:

pasted_file (123×352 px, 17 KB)

italics:

pasted_file (119×393 px, 15 KB)

black:

pasted_file (165×384 px, 20 KB)

yeah, I did the dark italics better. thanks!

what's the css for "dark"? I've used color: black.

black is fine too in this case

chad edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2016, 11:54 PM
This revision was automatically updated to reflect the committed changes.